linux-kernel - Re: [PATCH net-next 0/4] mlx5: Support setting a parent for a devlink rate node

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <358039ad-930d-464a-9a77-9bc1554ed6c5@intel.com>
Date: Thu, 13 Mar 2025 15:27:18 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Tariq Toukan <tariqt@...dia.com>, "David S. Miller" <davem@...emloft.net>,
	Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski <kuba@...nel.org>, "Paolo
 Abeni" <pabeni@...hat.com>, Andrew Lunn <andrew+netdev@...n.ch>
CC: Gal Pressman <gal@...dia.com>, Mark Bloch <mbloch@...dia.com>, "Moshe
 Shemesh" <moshe@...dia.com>, Saeed Mahameed <saeedm@...dia.com>, "Leon
 Romanovsky" <leon@...nel.org>, <netdev@...r.kernel.org>,
	<linux-rdma@...r.kernel.org>, <linux-kernel@...r.kernel.org>, Carolina Jubran
	<cjubran@...dia.com>, Cosmin Ratiu <cratiu@...dia.com>, Dragos Tatulea
	<dtatulea@...dia.com>
Subject: Re: [PATCH net-next 0/4] mlx5: Support setting a parent for a devlink
 rate node



On 3/10/2025 2:26 PM, Tariq Toukan wrote:
> Hi,
> 
> This series by Carolina adds mlx5 support for the setting of a parent to
> devlink rate nodes.
> 
> By introducing a hierarchical level to scheduling nodes, these changes
> allow for more granular control over bandwidth allocation and isolation
> of Virtual Functions.
> 
> Function renaming for parent setting on leafs:
> - net/mlx5: Rename devlink rate parent set function for leaf nodes
> 
> Add support for hierarchy level tracking:
> - net/mlx5: Introduce hierarchy level tracking on scheduling nodes
> - net/mlx5: Preserve rate settings when creating a rate node
> 
> Support setting parent for rate nodes:
> - net/mlx5: Add support for setting parent of nodes
> 
> Regards,
> Tariq
> 
> Carolina Jubran (4):
>   net/mlx5: Rename devlink rate parent set function for leaf nodes
>   net/mlx5: Introduce hierarchy level tracking on scheduling nodes
>   net/mlx5: Preserve rate settings when creating a rate node
>   net/mlx5: Add support for setting parent of nodes
> 

Nice work. The whole series was a pleasant read.

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>

>  .../net/ethernet/mellanox/mlx5/core/devlink.c |   3 +-
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.c | 146 ++++++++++++++++--
>  .../net/ethernet/mellanox/mlx5/core/esw/qos.h |  12 +-
>  3 files changed, 143 insertions(+), 18 deletions(-)
> 
> 
> base-commit: 8ef890df4031121a94407c84659125cbccd3fdbe