linux-kernel - Re: [PATCH net-next 2/3] stmmac: Remove pcim

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <89d99e2f-1189-42dc-8284-bab874820aa4@intel.com>
Date: Thu, 13 Mar 2025 15:33:19 -0700
From: Jacob Keller <jacob.e.keller@...el.com>
To: Philipp Stanner <phasta@...nel.org>, Andrew Lunn <andrew+netdev@...n.ch>,
	"David S. Miller" <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>,
	Jakub Kicinski <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, "Maxime
 Coquelin" <mcoquelin.stm32@...il.com>, Alexandre Torgue
	<alexandre.torgue@...s.st.com>, Yanteng Si <si.yanteng@...ux.dev>, "Huacai
 Chen" <chenhuacai@...nel.org>, Yinggang Gu <guyinggang@...ngson.cn>, "Serge
 Semin" <fancer.lancer@...il.com>, Philipp Stanner <pstanner@...hat.com>
CC: <netdev@...r.kernel.org>, <linux-stm32@...md-mailman.stormreply.com>,
	<linux-arm-kernel@...ts.infradead.org>, <linux-kernel@...r.kernel.org>,
	Andrew Lunn <andrew@...n.ch>, Henry Chen <chenx97@...c.io>
Subject: Re: [PATCH net-next 2/3] stmmac: Remove pcim_* functions for driver
 detach



On 3/13/2025 9:14 AM, Philipp Stanner wrote:
> Functions prefixed with "pcim_" are managed devres functions which
> perform automatic cleanup once the driver unloads. It is, thus, not
> necessary to call any cleanup functions in remove() callbacks.
> 
> Remove the pcim_ cleanup function calls in the remove() callbacks.
> 
> Signed-off-by: Philipp Stanner <phasta@...nel.org>
> Reviewed-by: Andrew Lunn <andrew@...n.ch>
> Reviewed-by: Yanteng Si <si.yanteng@...ux.dev>
> Tested-by: Henry Chen <chenx97@...c.io>
> ---

Reviewed-by: Jacob Keller <jacob.e.keller@...el.com>