linux-kernel - Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAMFSARdJgVQitDWmszbhSiVfu4hCoyyNVj3LPHb+7wq64C1BiA@mail.gmail.com>
Date: Thu, 13 Mar 2025 16:29:01 -0700
From: Jameson Thies <jthies@...gle.com>
To: kernel test robot <lkp@...el.com>
Cc: tzungbi@...nel.org, ukaszb@...omium.org, bleung@...omium.org, 
	heikki.krogerus@...ux.intel.com, robh+dt@...nel.org, 
	krzysztof.kozlowski+dt@...aro.org, groeck@...omium.org, swboyd@...omium.org, 
	akuchynski@...omium.org, llvm@...ts.linux.dev, oe-kbuild-all@...ts.linux.dev, 
	devicetree@...r.kernel.org, chrome-platform@...ts.linux.dev, 
	linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is
 defined in OF or ACPI

Echoing my response on patch 1/3, thank you for taking a look at this.
I’ll follow up with a v2 series to address your comments and resolve
the build issues. Additional responses below.

> > devices will be created automatically. None of parent devices should
> > ever check if the child exist to create a child - it makes no sense.
>
> This is still valid - none of parents should be poking around to see if
> there is a child or not. The core handles it, DT handles it etc.
>

Understood, we can remove this for DT. We need to keep part of this
check for ACPI because there are platforms which need this driver and
haven't defined proper ACPI nodes in their FW to load cros_ec_ucsi.

Thanks,
Jameson