linux-kernel - Re: Does ceph_fill_inode() mishandle I

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <1675539.1741909055@warthog.procyon.org.uk>
Date: Thu, 13 Mar 2025 23:37:35 +0000
From: David Howells <dhowells@...hat.com>
To: Jeff Layton <jlayton@...nel.org>
Cc: dhowells@...hat.com, slava@...eyko.com,
    Alex Markuze <amarkuze@...hat.com>, Xiubo Li <xiubli@...hat.com>,
    Ilya Dryomov <idryomov@...il.com>,
    Alexander Viro <viro@...iv.linux.org.uk>,
    Christian Brauner <brauner@...nel.org>, ceph-devel@...r.kernel.org,
    linux-fsdevel@...r.kernel.org, linux-kernel@...r.kernel.org,
    Slava.Dubeyko@....com
Subject: Re: Does ceph_fill_inode() mishandle I_NEW?

Jeff Layton <jlayton@...nel.org> wrote:

> I don't think that can happen. An I_NEW inode hasn't been properly
> hashed yet, so nothing should be able to find it until
> unlock_new_inode() is called.

That's not where the issue lies.  I'm talking about *after* I_NEW has been
cleared.

Imagine you have a file that has hard links in several directories.  Can
simultaneous lookup on a number of those hard links result in you going
through ceph_fill_inode() a number of times in parallel?

David