linux-kernel - Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <52e592c5-7f97-4b7b-bcf1-1bca34c716e1@linaro.org>
Date: Thu, 13 Mar 2025 08:11:40 +0100
From: Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>
To: Jameson Thies <jthies@...gle.com>, tzungbi@...nel.org,
 ukaszb@...omium.org, bleung@...omium.org, heikki.krogerus@...ux.intel.com,
 robh+dt@...nel.org, krzysztof.kozlowski+dt@...aro.org, groeck@...omium.org,
 swboyd@...omium.org, akuchynski@...omium.org
Cc: devicetree@...r.kernel.org, chrome-platform@...ts.linux.dev,
 linux-kernel@...r.kernel.org, linux-usb@...r.kernel.org
Subject: Re: [PATCH v1 3/3] mfd: cros_ec: Don't add cros_ec_ucsi if it is
 defined in OF or ACPI

On 12/03/2025 20:59, Jameson Thies wrote:
> Check for cros_ec_ucsi to be defined in the OF device tree or an ACPI
> node. If it is defined by either OF or ACPI, it does not need to be
> added as a subdevice of cros_ec_dev.

No, it does not have to. You just populate the children and appropriate
devices will be created automatically. None of parent devices should
ever check if the child exist to create a child - it makes no sense.

Best regards,
Krzysztof