linux-kernel - Re: [PATCH 5/5] media/i2c: max96717: allow user to override operation mode from DT

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <64b82675410733368fa420d29b31921bba4e224d.camel@collabora.com>
Date: Thu, 13 Mar 2025 08:46:41 +0100
From: Julien Massot <julien.massot@...labora.com>
To: Laurentiu Palcu <laurentiu.palcu@....nxp.com>
Cc: Mauro Carvalho Chehab <mchehab@...nel.org>,
 linux-kernel@...r.kernel.org, 	linux-media@...r.kernel.org
Subject: Re: [PATCH 5/5] media/i2c: max96717: allow user to override
 operation mode from DT

Hi Laurentiu,

> > > @@ -1101,6 +1110,9 @@ static int max96717_parse_dt(struct max96717_priv *priv)
> > >  
> > >  	priv->mipi_csi2 = vep.bus.mipi_csi2;
> > >  
> > > +	if (fwnode_property_present(dev_fwnode(dev), "maxim,cfg-mode-override"))
> > > +		priv->mode_override = true;
> > > +
> > 	source_fwnode = fwnode_graph_get_endpoint_by_id(dev_fwnode(dev),
> > 							MAX96717_PAD_SOURCE, 0, 0);
> > 	if (fwnode_property_present(source_fwnode, "maxim,tunnel-mode")) {
> > 		priv->mode_override = true;
> > 		priv->mode = GMSL2_MODE_TUNNEL;
> > 	}
> 
> So, I don't think the boolean 'maxim,tunnel-mode' would work well when
> the pin configuration is 'tunnel' and the user wants to switch to
> 'pixel'. Maybe, replace the boolean 'maxim,cfg-mode-override' property
> with an optional enum property 'maxim,cfg-mode'? Does that sound better?

Yes, please see my comment on patch 3/5

Regards,
--
Julien