linux-kernel - [PATCH] drm/omap: Remove unnecessary NULL check before clk_prepare_enable/clk_disable

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-Id: <20250313083756.2481659-1-nichen@iscas.ac.cn>
Date: Thu, 13 Mar 2025 16:37:56 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: tomi.valkeinen@...asonboard.com,
	maarten.lankhorst@...ux.intel.com,
	mripard@...nel.org,
	tzimmermann@...e.de,
	airlied@...il.com,
	simona@...ll.ch
Cc: dri-devel@...ts.freedesktop.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>
Subject: [PATCH] drm/omap: Remove unnecessary NULL check before clk_prepare_enable/clk_disable_unprepare

clk_prepare_enable() and clk_disable_unprepare() already checked
NULL clock parameter.Remove unneeded NULL check for clk here.

Signed-off-by: Chen Ni <nichen@...as.ac.cn>
---
 drivers/gpu/drm/omapdrm/dss/venc.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/omapdrm/dss/venc.c b/drivers/gpu/drm/omapdrm/dss/venc.c
index aaeef603682c..7d521840d4f6 100644
--- a/drivers/gpu/drm/omapdrm/dss/venc.c
+++ b/drivers/gpu/drm/omapdrm/dss/venc.c
@@ -882,8 +882,7 @@ static __maybe_unused int venc_runtime_suspend(struct device *dev)
 {
 	struct venc_device *venc = dev_get_drvdata(dev);
 
-	if (venc->tv_dac_clk)
-		clk_disable_unprepare(venc->tv_dac_clk);
+	clk_disable_unprepare(venc->tv_dac_clk);
 
 	return 0;
 }
@@ -892,8 +891,7 @@ static __maybe_unused int venc_runtime_resume(struct device *dev)
 {
 	struct venc_device *venc = dev_get_drvdata(dev);
 
-	if (venc->tv_dac_clk)
-		clk_prepare_enable(venc->tv_dac_clk);
+	clk_prepare_enable(venc->tv_dac_clk);
 
 	return 0;
 }
-- 
2.25.1