linux-kernel - Re: [PATCH v1] platform/x86: intel_pmc_ipc: add option to build without ACPI

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <21d10c76-6f8b-4050-aa7d-59b12b3c5e85@linux.intel.com>
Date: Thu, 13 Mar 2025 16:59:21 +0800
From: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
To: Andy Shevchenko <andy.shevchenko@...il.com>
Cc: Hans de Goede <hdegoede@...hat.com>,
 Ilpo Järvinen <ilpo.jarvinen@...ux.intel.com>,
 David E Box <david.e.box@...ux.intel.com>,
 platform-driver-x86@...r.kernel.org, linux-kernel@...r.kernel.org
Subject: Re: [PATCH v1] platform/x86: intel_pmc_ipc: add option to build
 without ACPI



On 12/3/2025 10:00 pm, Andy Shevchenko wrote:
> On Wed, Mar 12, 2025 at 1:23 PM Choong Yong Liang
> <yong.liang.choong@...ux.intel.com> wrote:
>> On 12/3/2025 3:54 pm, Andy Shevchenko wrote:
>>> On Wed, Mar 12, 2025 at 4:30 AM Choong Yong Liang
>>> <yong.liang.choong@...ux.intel.com> wrote:
> 
> ...
> 
>> Thank you for your detailed feedback and suggestions. I'll make the
>> necessary adjustments to the patch based on your comments above.
>>
>>>> Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
>>>> Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
>>>
>>> This is wrong as either it's a wrong tag (SoB --> Suggested-by?), or
>>> missing Co-developed-by, or wrong order (but in that case David should
>>> have sent the patch).
>>>
>> I believe the sequence is still correct, as the solution was provided by
>> David, and he should be the main author. I'm just the submitter, so my
>> sign-off should be placed last.
> 
> You are the submitter *and* the author in this case. As I said, that
> SoB chain is wrong in its current form.
> 
Hi Andy,

I believe this time I have correctly attributed the authorship by following 
the guide from:
https://docs.kernel.org/process/submitting-patches.html#when-to-use-acked-by-cc-and-co-developed-by
---
From: David E. Box <david.e.box@...ux.intel.com>

<changelog>

Signed-off-by: David E. Box <david.e.box@...ux.intel.com>
Co-developed-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
Signed-off-by: Choong Yong Liang <yong.liang.choong@...ux.intel.com>
---