linux-kernel - Re: [PATCH] wifi: ath12k: fix 5GHz operation on wideband QCN9274 radios

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <c10b95de-f3b3-9506-f4eb-3d668faa9165@quicinc.com>
Date: Thu, 13 Mar 2025 15:06:15 +0530
From: Vasanthakumar Thiagarajan <quic_vthiagar@...cinc.com>
To: Mantas Pucka <mantas@...vices.com>, <ath12k@...ts.infradead.org>
CC: Johannes Berg <johannes@...solutions.net>,
        Jeff Johnson
	<jjohnson@...nel.org>, <linux-wireless@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] wifi: ath12k: fix 5GHz operation on wideband QCN9274
 radios



On 3/13/2025 2:30 PM, Mantas Pucka wrote:
> Currently ath12k_mac_setup_ht_vht_cap() incorrectly assumes that QCN9274
> radios with 6GHz band can't support 5GHz as well. This prevents the
> addition of HT and VHT capabilities for the 5GHz band. Since QCN9274 is
> capable of operating in multiple bands, remove the 6GHz support check and
> exception for single_pdev_only (i.e. WCN7850).
> 
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.4.1-00199-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Mantas Pucka <mantas@...vices.com>
> ---
>   drivers/net/wireless/ath/ath12k/mac.c | 4 +---
>   1 file changed, 1 insertion(+), 3 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/mac.c b/drivers/net/wireless/ath/ath12k/mac.c
> index dfa05f0ee6c9f7356634ab55a6d9c0b4064645a9..aea3ad01b0671fd236ee70864aee4c1e65f564db 100644
> --- a/drivers/net/wireless/ath/ath12k/mac.c
> +++ b/drivers/net/wireless/ath/ath12k/mac.c
> @@ -6484,9 +6484,7 @@ static void ath12k_mac_setup_ht_vht_cap(struct ath12k *ar,
>   						    rate_cap_rx_chainmask);
>   	}
>   
> -	if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP &&
> -	    (ar->ab->hw_params->single_pdev_only ||
> -	     !ar->supports_6ghz)) {
> +	if (cap->supported_bands & WMI_HOST_WLAN_5G_CAP) {
>   		band = &ar->mac.sbands[NL80211_BAND_5GHZ];
>   		ht_cap = cap->band[NL80211_BAND_5GHZ].ht_cap_info;
>   		if (ht_cap_info)
> 

NAK

Multi-band configuration is supported for scan radio only even that requires
additional driver changes.