linux-kernel - Re: [PATCH v6 2/2] i2c: spacemit: add support for SpacemiT K1 SoC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <nrmoj7gookedlz2e3fgu3hvn3s5fc6vrxgjueynyp5orj63k4b@cqlhflioxv7h>
Date: Thu, 13 Mar 2025 01:10:11 +0100
From: Andi Shyti <andi.shyti@...nel.org>
To: Alex Elder <elder@...cstar.com>
Cc: Troy Mitchell <troymitchell988@...il.com>, 
	Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, 
	Conor Dooley <conor+dt@...nel.org>, Yixun Lan <dlan@...too.org>, linux-riscv@...ts.infradead.org, 
	linux-i2c@...r.kernel.org, devicetree@...r.kernel.org, linux-kernel@...r.kernel.org, 
	spacemit@...ts.linux.dev, Guodong Xu <guodong@...cstar.com>
Subject: Re: [PATCH v6 2/2] i2c: spacemit: add support for SpacemiT K1 SoC

Hi,

On Tue, Mar 11, 2025 at 08:46:31PM -0500, Alex Elder wrote:
> On 3/7/25 7:13 AM, Troy Mitchell wrote:
> > This patch introduces basic I2C support for the SpacemiT K1 SoC,
> > utilizing interrupts for transfers.
> > 
> > The driver has been tested using i2c-tools on a Bananapi-F3 board,
> > and basic I2C read/write operations have been confirmed to work.
> > 
> > Signed-off-by: Troy Mitchell <troymitchell988@...il.com>
> 
> I have a bunch of really small suggestions.  Please consider
> them, but whatever you choose to do this looks good to me.
> 
> Reviewed-by: Alex Elder <elder@...cstar.com>

thanks Alex for reviewing, I will wait for a v7 with your
suggestions.

Overall the patch looks good to me, as well, even though I have
to give some credit to Wolfram's previous comments about the
i2c-pxa similarities.

I checked the two drivers last night and I can see some
similarities, on the other hand I also understand that it might
require some extra effort.

I want to check it again, though, before applying.

Andi