linux-kernel - Re: [PATCH v2 02/10] dt-bindings: msm: dsi-controller-main: document the SA8775P DSI CTRL

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <c1e554f3-cf4f-42ba-aa75-94c8b0a13ff3@quicinc.com>
Date: Thu, 13 Mar 2025 15:18:28 +0530
From: Ayushi Makhija <quic_amakhija@...cinc.com>
To: Krzysztof Kozlowski <krzk@...nel.org>
CC: <linux-arm-msm@...r.kernel.org>, <dri-devel@...ts.freedesktop.org>,
        <freedreno@...ts.freedesktop.org>, <devicetree@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>, <robdclark@...il.com>,
        <dmitry.baryshkov@...aro.org>, <sean@...rly.run>,
        <marijn.suijten@...ainline.org>, <andersson@...nel.org>,
        <robh@...nel.org>, <robh+dt@...nel.org>, <krzk+dt@...nel.org>,
        <konradybcio@...nel.org>, <conor+dt@...nel.org>,
        <andrzej.hajda@...el.com>, <neil.armstrong@...aro.org>,
        <rfoss@...nel.org>, <Laurent.pinchart@...asonboard.com>,
        <jonas@...boo.se>, <jernej.skrabec@...il.com>,
        <quic_abhinavk@...cinc.com>, <quic_rajeevny@...cinc.com>,
        <quic_vproddut@...cinc.com>, <quic_jesszhan@...cinc.com>
Subject: Re: [PATCH v2 02/10] dt-bindings: msm: dsi-controller-main: document
 the SA8775P DSI CTRL



On 3/12/2025 5:14 PM, Krzysztof Kozlowski wrote:
> On Tue, Mar 11, 2025 at 05:54:37PM +0530, Ayushi Makhija wrote:
>> diff --git a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> index ffbd1dc9470e..3621e3f12b65 100644
>> --- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> +++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
>> @@ -23,6 +23,7 @@ properties:
>>                - qcom,msm8996-dsi-ctrl
>>                - qcom,msm8998-dsi-ctrl
>>                - qcom,qcm2290-dsi-ctrl
>> +              - qcom,sa8775p-dsi-ctrl
> 
> That's incomplete, where is the rest of updates in the file? Not
> needed?
> 
> Best regards,
> Krzysztof
> 

Hi Krzysztof,

Thanks, for the review.

Each compatible string has a different set of clocks which are associated with it.

Sorry, I forget to add qcom,sa8775p-dsi-ctrl compatible based on the set of clocks which are associated with it.
Will add it in next patch.

--- a/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
+++ b/Documentation/devicetree/bindings/display/msm/dsi-controller-main.yaml
@@ -349,6 +349,7 @@ allOf:
         compatible:
           contains:
             enum:
+              - qcom,sa8775p-dsi-ctrl
               - qcom,sc7180-dsi-ctrl
               - qcom,sc7280-dsi-ctrl
               - qcom,sm6150-dsi-ctrl

The remaining content in the file will stay the same, no other changes are needed.

Thanks,
Ayushi