linux-kernel - Re: [PATCH 6/7] x86, lib: Add wbinvd and wbnoinvd helpers to target multiple CPUs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <fe6773324ed53b5b0df95bf816e4d7050a4d958e.camel@intel.com>
Date: Thu, 13 Mar 2025 10:19:37 +0000
From: "Huang, Kai" <kai.huang@...el.com>
To: "tglx@...utronix.de" <tglx@...utronix.de>, "x86@...nel.org"
	<x86@...nel.org>, "mingo@...hat.com" <mingo@...hat.com>,
	"pbonzini@...hat.com" <pbonzini@...hat.com>, "seanjc@...gle.com"
	<seanjc@...gle.com>, "bp@...en8.de" <bp@...en8.de>,
	"dave.hansen@...ux.intel.com" <dave.hansen@...ux.intel.com>
CC: "szy0127@...u.edu.cn" <szy0127@...u.edu.cn>, "kvm@...r.kernel.org"
	<kvm@...r.kernel.org>, "thomas.lendacky@....com" <thomas.lendacky@....com>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "Zhang,
 Mingwei" <mizhang@...gle.com>, "kevinloughlin@...gle.com"
	<kevinloughlin@...gle.com>
Subject: Re: [PATCH 6/7] x86, lib: Add wbinvd and wbnoinvd helpers to target
 multiple CPUs

On Wed, 2025-02-26 at 17:48 -0800, Sean Christopherson wrote:
> From: Zheyun Shen <szy0127@...u.edu.cn>
> 
> Extract KVM's open-coded calls to do writeback caches on multiple CPUs to
> common library helpers for both WBINVD and WBNOINVD (KVM will use both).
> Put the onus on the caller to check for a non-empty mask to simplify the
> SMP=n implementation, e.g. so that it doesn't need to check that the one
> and only CPU in the system is present in the mask.
> 
> Signed-off-by: Zheyun Shen <szy0127@...u.edu.cn>
> Reviewed-by: Tom Lendacky <thomas.lendacky@....com>
> Link: https://lore.kernel.org/r/20250128015345.7929-2-szy0127@sjtu.edu.cn
> [sean: move to lib, add SMP=n helpers, clarify usage]
> Signed-off-by: Sean Christopherson <seanjc@...gle.com>

Assume the issue pointed by Zheyun will be addressed:

Acked-by: Kai Huang <kai.huang@...el.com>