linux-kernel - Re: [PATCH v3 1/8] iommu/amd: Refactor AMD IOMMU debugfs initial setup

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <64014aa9-4d33-4178-97bc-719c2db00d93@amd.com>
Date: Thu, 13 Mar 2025 15:57:21 +0530
From: Vasant Hegde <vasant.hegde@....com>
To: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@....com>,
 joro@...tes.org, suravee.suthikulpanit@....com, will@...nel.org,
 robin.murphy@....com, linux-kernel@...r.kernel.org, iommu@...ts.linux.dev
Subject: Re: [PATCH v3 1/8] iommu/amd: Refactor AMD IOMMU debugfs initial
 setup



On 2/6/2025 11:29 AM, Dheeraj Kumar Srivastava wrote:
> Rearrange initial setup of AMD IOMMU debugfs to segregate per IOMMU
> setup and setup which is common for all IOMMUs. This ensures that common
> debugfs paths (introduced in subsequent patches) are created only once
> instead of being created for each IOMMU.
> 
> With the change, there is no need to use lock as amd_iommu_debugfs_setup()
> will be called only once during AMD IOMMU initialization. So remove lock
> acquisition in amd_iommu_debugfs_setup().
> 
> Signed-off-by: Dheeraj Kumar Srivastava <dheerajkumar.srivastava@....com>
> Reviewed-by: Suravee Suthikulpanit <suravee.suthikulpanit@....com>

Reviewed-by: Vasant Hegde <vasant.hegde@....com>

-Vasant