linux-kernel - Re: [PATCH v2 19/22] rust: pin-init: miscellaneous synchronization with the user-space version

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <m2o6y5xjf2.fsf@kloenk.dev>
Date: Thu, 13 Mar 2025 12:24:33 +0100
From: Fiona Behrens <me@...enk.dev>
To: Benno Lossin <benno.lossin@...ton.me>
Cc: Miguel Ojeda <ojeda@...nel.org>,  Alex Gaynor <alex.gaynor@...il.com>,
  Boqun Feng <boqun.feng@...il.com>,  Gary Guo <gary@...yguo.net>,
  Björn
 Roy Baron <bjorn3_gh@...tonmail.com>,  Andreas Hindborg
 <a.hindborg@...nel.org>,  Alice Ryhl <aliceryhl@...gle.com>,  Trevor Gross
 <tmgross@...ch.edu>,  rust-for-linux@...r.kernel.org,
  linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 19/22] rust: pin-init: miscellaneous synchronization
 with the user-space version

Benno Lossin <benno.lossin@...ton.me> writes:

> Remove the last differences between the kernel version and the
> user-space version.
>
> Signed-off-by: Benno Lossin <benno.lossin@...ton.me>
> Reviewed-by: Andreas Hindborg <a.hindborg@...nel.org>
> Tested-by: Andreas Hindborg <a.hindborg@...nel.org>

Reviewed-by: Fiona Behrens <me@...enk.dev>

> ---
>  rust/pin-init/internal/src/lib.rs | 5 ++---
>  rust/pin-init/src/__internal.rs   | 2 +-
>  rust/pin-init/src/lib.rs          | 2 --
>  3 files changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/rust/pin-init/internal/src/lib.rs b/rust/pin-init/internal/src/lib.rs
> index 30e145f80bc0..babe5e878550 100644
> --- a/rust/pin-init/internal/src/lib.rs
> +++ b/rust/pin-init/internal/src/lib.rs
> @@ -14,6 +14,8 @@
>  //
>  // Remove once we have `proc_macro2` in the kernel.
>  #![allow(clippy::useless_conversion)]
> +// Documentation is done in the pin-init crate instead.
> +#![allow(missing_docs)]
>  
>  use proc_macro::TokenStream;
>  
> @@ -30,19 +32,16 @@
>  mod pinned_drop;
>  mod zeroable;
>  
> -#[allow(missing_docs)]
>  #[proc_macro_attribute]
>  pub fn pin_data(inner: TokenStream, item: TokenStream) -> TokenStream {
>      pin_data::pin_data(inner.into(), item.into()).into()
>  }
>  
> -#[allow(missing_docs)]
>  #[proc_macro_attribute]
>  pub fn pinned_drop(args: TokenStream, input: TokenStream) -> TokenStream {
>      pinned_drop::pinned_drop(args.into(), input.into()).into()
>  }
>  
> -#[allow(missing_docs)]
>  #[proc_macro_derive(Zeroable)]
>  pub fn derive_zeroable(input: TokenStream) -> TokenStream {
>      zeroable::derive(input.into()).into()
> diff --git a/rust/pin-init/src/__internal.rs b/rust/pin-init/src/__internal.rs
> index 7f7744d48575..557b5948cddc 100644
> --- a/rust/pin-init/src/__internal.rs
> +++ b/rust/pin-init/src/__internal.rs
> @@ -14,7 +14,7 @@
>  ///
>  /// [nomicon]: https://doc.rust-lang.org/nomicon/subtyping.html
>  /// [this table]: https://doc.rust-lang.org/nomicon/phantom-data.html#table-of-phantomdata-patterns
> -pub(super) type Invariant<T> = PhantomData<fn(*mut T) -> *mut T>;
> +pub(crate) type Invariant<T> = PhantomData<fn(*mut T) -> *mut T>;
>  
>  /// Module-internal type implementing `PinInit` and `Init`.
>  ///
> diff --git a/rust/pin-init/src/lib.rs b/rust/pin-init/src/lib.rs
> index a00288133ae3..45880ffa81bb 100644
> --- a/rust/pin-init/src/lib.rs
> +++ b/rust/pin-init/src/lib.rs
> @@ -349,8 +349,6 @@
>  ///     }
>  /// }
>  /// ```
> -///
> -/// [`pin_init!`]: crate::pin_init
>  pub use ::pin_init_internal::pin_data;
>  
>  /// Used to implement `PinnedDrop` safely.