linux-kernel - Re: [PATCH v1 1/1] ASoC: SOF: ipc4-topology: Allocate ref

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9LBMEvlRoiVNsvi@smile.fi.intel.com>
Date: Thu, 13 Mar 2025 13:27:44 +0200
From: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
To: Péter Ujfalusi <peter.ujfalusi@...ux.intel.com>
Cc: Mark Brown <broonie@...nel.org>,
	Pierre-Louis Bossart <pierre-louis.bossart@...ux.dev>,
	Ranjani Sridharan <ranjani.sridharan@...ux.intel.com>,
	Bard Liao <yung-chuan.liao@...ux.intel.com>,
	sound-open-firmware@...a-project.org, linux-sound@...r.kernel.org,
	linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
	Liam Girdwood <lgirdwood@...il.com>,
	Daniel Baluta <daniel.baluta@....com>,
	Kai Vehmanen <kai.vehmanen@...ux.intel.com>,
	Jaroslav Kysela <perex@...ex.cz>, Takashi Iwai <tiwai@...e.com>,
	Nathan Chancellor <nathan@...nel.org>,
	Nick Desaulniers <nick.desaulniers+lkml@...il.com>,
	Bill Wendling <morbo@...gle.com>,
	Justin Stitt <justinstitt@...gle.com>
Subject: Re: [PATCH v1 1/1] ASoC: SOF: ipc4-topology: Allocate ref_params on
 stack

On Thu, Mar 13, 2025 at 01:21:17PM +0200, Péter Ujfalusi wrote:
> On 12/03/2025 18:05, Andy Shevchenko wrote:
> > Currently the compiler (clang 19.1.7) is not happy about the size of
> > the stack frame in sof_ipc4_prepare_copier_module:
> > 
> > sound/soc/sof/ipc4-topology.c:1800:1: error: stack frame size (1288) exceeds limit (1024) in 'sof_ipc4_prepare_copier_module' [-Werror,-Wframe-larger-than]
> >  1800 | sof_ipc4_prepare_copier_module(struct snd_sof_widget *swidget,
> >       | ^
> > 
> > Work around this by allocating ref_params on stack, as it looks the biggest
> > variable on stack right now.
> > 
> > Note, this only happens when compile for 32-bit machines (x86_32 in my case).
> 
> I don't have better idea for fix, apart from somehow refactor this huge
> function.
> Thank you for the fix,
> 
> Acked-by: Peter Ujfalusi <peter.ujfalusi@...ux.intel.com>

Thank you for looking into it!

-- 
With Best Regards,
Andy Shevchenko