linux-kernel - Re: [PATCH v3] genirq: Fix parameter type in declaration and definition

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <87o6y55fq4.ffs@tglx>
Date: Thu, 13 Mar 2025 12:31:47 +0100
From: Thomas Gleixner <tglx@...utronix.de>
To: ye.xingchen@....com.cn
Cc: linux-kernel@...r.kernel.org
Subject: Re: [PATCH v3] genirq: Fix parameter type in declaration and
 definition

On Thu, Mar 13 2025 at 16:18, ye xingchen wrote:

$Subject: ... Fix ...

There is nothing to fix here. It's correct code.

> This patch aligns the parameter name in the definition with the

See other reply.

> --- a/kernel/irq/manage.c
> +++ b/kernel/irq/manage.c
> @@ -2860,7 +2860,7 @@ EXPORT_SYMBOL_GPL(irq_get_irqchip_state);
>   *	interrupt controller has per-cpu registers.
>   */
>  int irq_set_irqchip_state(unsigned int irq, enum irqchip_irq_state which,
> -			  bool val)
> +			  bool state)

Now the kernel doc of that function is inconsistent.

You are not making anything more consistent, you are actively making it
worse. Please stop sending half thought out patches every half an hour.

Thanks,

        tglx