linux-kernel - Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <ef190ba8-a5c7-4a1a-90e6-2610de00e4ed@sirena.org.uk>
Date: Thu, 13 Mar 2025 13:25:18 +0000
From: Mark Brown <broonie@...nel.org>
To: Lee Jones <lee@...nel.org>
Cc: Artur Weber <aweber.kernel@...il.com>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Stanislav Jakubek <stano.jakubek@...il.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing
 function

On Thu, Mar 13, 2025 at 01:20:36PM +0000, Lee Jones wrote:
> On Tue, 04 Mar 2025, Artur Weber wrote:

> > +	if (id != bcm590xx->pmu_id) {
> > +		dev_err(bcm590xx->dev,
> > +			"Incorrect ID for %s: expected %x, got %x. Check your DT compatible.\n",
> 
> Isn't it more likely that the H/W this is being executed on is
> unsupported?  If so, say that instead.

Given that the compatibles are device specific the driver shouldn't be
binding if the device is unsupported.

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)