linux-kernel - [PATCH -next V2] xfs: remove unnecessary NULL check before kvfree()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250313032859.2094462-1-nichen@iscas.ac.cn>
Date: Thu, 13 Mar 2025 11:28:59 +0800
From: Chen Ni <nichen@...as.ac.cn>
To: cem@...nel.org,
	djwong@...nel.org,
	hch@....de
Cc: linux-xfs@...r.kernel.org,
	linux-kernel@...r.kernel.org,
	Chen Ni <nichen@...as.ac.cn>,
	Carlos Maiolino <cmaiolino@...hat.com>
Subject: [PATCH -next V2] xfs: remove unnecessary NULL check before kvfree()

Remove unnecessary NULL check before kvfree() reported by
Coccinelle/coccicheck and the semantic patch at
scripts/coccinelle/free/ifnullfree.cocci.

Signed-off-by: Chen Ni <nichen@...as.ac.cn>
Reviewed-by: Carlos Maiolino <cmaiolino@...hat.com>
---
Changelog:

v1 -> v2:

1. rebase it on top of for-next.
---
 fs/xfs/xfs_rtalloc.c | 3 +--
 1 file changed, 1 insertion(+), 2 deletions(-)

diff --git a/fs/xfs/xfs_rtalloc.c b/fs/xfs/xfs_rtalloc.c
index 9a99629d7de4..3aa222ea9500 100644
--- a/fs/xfs/xfs_rtalloc.c
+++ b/fs/xfs/xfs_rtalloc.c
@@ -1212,8 +1212,7 @@ xfs_growfs_rtg(
 			goto out_error;
 	}
 
-	if (old_rsum_cache)
-		kvfree(old_rsum_cache);
+	kvfree(old_rsum_cache);
 	goto out_rele;
 
 out_error:
-- 
2.25.1