linux-kernel - Re: [PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CANiq72njsmokSeQG=nzRDUUmYHnpRCGNwWJ1ZXj_khxXwrZxEQ@mail.gmail.com>
Date: Fri, 14 Mar 2025 15:41:02 +0100
From: Miguel Ojeda <miguel.ojeda.sandonis@...il.com>
To: Benjamin Tissoires <bentiss@...nel.org>
Cc: Rahul Rameshbabu <sergeantsagara@...tonmail.com>, linux-kernel@...r.kernel.org, 
	rust-for-linux@...r.kernel.org, linux-input@...r.kernel.org, 
	dri-devel@...ts.freedesktop.org, Jiri Kosina <jikos@...nel.org>, 
	Miguel Ojeda <ojeda@...nel.org>, Alex Gaynor <alex.gaynor@...il.com>, 
	Boqun Feng <boqun.feng@...il.com>, Gary Guo <gary@...yguo.net>, 
	Björn Roy Baron <bjorn3_gh@...tonmail.com>, 
	Benno Lossin <benno.lossin@...ton.me>, Andreas Hindborg <a.hindborg@...nel.org>, 
	Alice Ryhl <aliceryhl@...gle.com>, Trevor Gross <tmgross@...ch.edu>, 
	Danilo Krummrich <dakr@...nel.org>, Julius Zint <julius@...t.sh>
Subject: Re: [PATCH RFC 2/3] rust: hid: USB Monitor Control Class driver

On Thu, Mar 13, 2025 at 5:58 PM Benjamin Tissoires <bentiss@...nel.org> wrote:
>
> skeletons are good for documentation, but not really for code review as
> they can not compile.
>
> You should make this patch part of a documentation in
> Documentation/hid/, and squash it with the next one (having a minimal
> full driver instead of skeleton+fill in the voids).

It could be part of the documentation of the `module_hid_driver!` for
instance, like we have done for other of those macros.

(In general, we try to use `Documentation/` for things that do not fit
as documentation for any of the code "items".)

Cheers,
Miguel