linux-kernel - Re: [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9RCZ_L6HS0GZhWL@kernel.org>
Date: Fri, 14 Mar 2025 16:51:19 +0200
From: Jarkko Sakkinen <jarkko@...nel.org>
To: Stefano Garzarella <sgarzare@...hat.com>
Cc: Peter Huewe <peterhuewe@....de>, linux-integrity@...r.kernel.org,
	Jason Gunthorpe <jgg@...pe.ca>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] tpm/tpm_ftpm_tee: fix struct ftpm_tee_private
 documentation

On Thu, Mar 13, 2025 at 10:37:17AM +0100, Stefano Garzarella wrote:
> The `state` member in `struct ftpm_tee_private` is in the documentation,
> but it has never been in the implementation since the commit 09e574831b27
> ("tpm/tpm_ftpm_tee: A driver for firmware TPM running inside TEE") that
> introduced it.
> 
> Remove it to have a match between documentation and implementation.
> 
> Signed-off-by: Stefano Garzarella <sgarzare@...hat.com>
> ---
>  drivers/char/tpm/tpm_ftpm_tee.h | 1 -
>  1 file changed, 1 deletion(-)
> 
> diff --git a/drivers/char/tpm/tpm_ftpm_tee.h b/drivers/char/tpm/tpm_ftpm_tee.h
> index f98daa7bf68c..e39903b7ea07 100644
> --- a/drivers/char/tpm/tpm_ftpm_tee.h
> +++ b/drivers/char/tpm/tpm_ftpm_tee.h
> @@ -21,7 +21,6 @@
>  /**
>   * struct ftpm_tee_private - fTPM's private data
>   * @chip:     struct tpm_chip instance registered with tpm framework.
> - * @state:    internal state
>   * @session:  fTPM TA session identifier.
>   * @resp_len: cached response buffer length.
>   * @resp_buf: cached response buffer.
> -- 
> 2.48.1
> 

Reviewed-by: Jarkko Sakkinen <jarkko@...nel.org>

[applying next week]


BR, Jarkko