linux-kernel - Re: [PATCH] dmaengine: xilinx_dma: Set dma

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-Id: <D8G31H1FDKXJ.3C3P6GDB2JBW@folker-schwesinger.de>
Date: Fri, 14 Mar 2025 15:09:15 +0000
From: "Folker Schwesinger" <dev@...ker-schwesinger.de>
To: "Thomas Gessler" <thomas.gessler@...eckmann-gmbh.de>,
 <dmaengine@...r.kernel.org>
Cc: "Vinod Koul" <vkoul@...nel.org>, "Michal Simek" <michal.simek@....com>,
 "Marek Vasut" <marex@...x.de>, "Radhey Shyam Pandey"
 <radhey.shyam.pandey@....com>, Uwe Kleine-König
 <u.kleine-koenig@...libre.com>, <linux-arm-kernel@...ts.infradead.org>,
 <linux-kernel@...r.kernel.org>
Subject: Re: [PATCH] dmaengine: xilinx_dma: Set dma_device directions

On Fri Mar 14, 2025 at 2:48 PM CET, Thomas Gessler wrote:
> Coalesce the direction bits from the enabled TX and/or RX channels into
> the directions bit mask of dma_device. Without this mask set,
> dma_get_slave_caps() in the DMAEngine fails, which prevents the driver
> from being used with an IIO DMAEngine buffer.
>
> Signed-off-by: Thomas Gessler <thomas.gessler@...eckmann-gmbh.de>

Tested-by: Folker Schwesinger <dev@...ker-schwesinger.de>

> ---
>  drivers/dma/xilinx/xilinx_dma.c | 4 ++++
>  1 file changed, 4 insertions(+)
>
> diff --git a/drivers/dma/xilinx/xilinx_dma.c b/drivers/dma/xilinx/xilinx_dma.c
> index 108a7287f4cd..641aaf0c0f1c 100644
> --- a/drivers/dma/xilinx/xilinx_dma.c
> +++ b/drivers/dma/xilinx/xilinx_dma.c
> @@ -3205,6 +3205,10 @@ static int xilinx_dma_probe(struct platform_device *pdev)
>  		}
>  	}
>  
> +	for (i = 0; i < xdev->dma_config->max_channels; i++)
> +		if (xdev->chan[i])
> +			xdev->common.directions |= xdev->chan[i]->direction;
> +
>  	if (xdev->dma_config->dmatype == XDMA_TYPE_VDMA) {
>  		for (i = 0; i < xdev->dma_config->max_channels; i++)
>  			if (xdev->chan[i])