linux-kernel - [PATCH] pmdomain: thead: fix TH1520_AON

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [thread-next>] [day] [month] [year] [list]

Message-Id: <20250314154834.4053416-1-arnd@kernel.org>
Date: Fri, 14 Mar 2025 16:48:31 +0100
From: Arnd Bergmann <arnd@...nel.org>
To: Drew Fustini <drew@...7.com>,
	Guo Ren <guoren@...nel.org>,
	Fu Wei <wefu@...hat.com>,
	Ulf Hansson <ulf.hansson@...aro.org>,
	Michal Wilczynski <m.wilczynski@...sung.com>
Cc: Arnd Bergmann <arnd@...db.de>,
	linux-riscv@...ts.infradead.org,
	linux-pm@...r.kernel.org,
	linux-kernel@...r.kernel.org
Subject: [PATCH] pmdomain: thead: fix TH1520_AON_PROTOCOL dependency

From: Arnd Bergmann <arnd@...db.de>

Kconfig treats the dependency as optional, but the header file only provides
normal declarations and no empty API stubs:

ld: fs/btrfs/extent_io.o: in function `writepage_delalloc':
extent_io.c:(.text+0x2b42): undefined reference to `__udivdi3'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_off':
th1520-pm-domains.c:(.text+0x57): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_power_on':
th1520-pm-domains.c:(.text+0x8a): undefined reference to `th1520_aon_power_update'
ld: drivers/pmdomain/thead/th1520-pm-domains.o: in function `th1520_pd_probe':
th1520-pm-domains.c:(.text+0xb8): undefined reference to `th1520_aon_init'
ld: th1520-pm-domains.c:(.text+0x1c6): undefined reference to `th1520_aon_power_update'

Since the firmware code can easily be enabled for compile testing, there
is no need to add stubs either, so just make it a hard dependency.

Fixes: dc9a897dbb03 ("pmdomain: thead: Add power-domain driver for TH1520")
Signed-off-by: Arnd Bergmann <arnd@...db.de>
---
 drivers/pmdomain/thead/Kconfig | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/pmdomain/thead/Kconfig b/drivers/pmdomain/thead/Kconfig
index c7a1ac0c61dc..7d52f8374b07 100644
--- a/drivers/pmdomain/thead/Kconfig
+++ b/drivers/pmdomain/thead/Kconfig
@@ -2,7 +2,7 @@
 
 config TH1520_PM_DOMAINS
 	tristate "Support TH1520 Power Domains"
-	depends on TH1520_AON_PROTOCOL || !TH1520_AON_PROTOCOL
+	depends on TH1520_AON_PROTOCOL
 	select REGMAP_MMIO
 	help
 	  This driver enables power domain management for the T-HEAD
-- 
2.39.5