linux-kernel - Re: [PATCH 00/13] selftests/bpf: Integrate test_xsk.c to test

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <a8c7e353-2e5f-4cdc-99fb-0937b8121b38@bootlin.com>
Date: Fri, 14 Mar 2025 17:08:31 +0100
From: Bastien Curutchet <bastien.curutchet@...tlin.com>
To: Maciej Fijalkowski <maciej.fijalkowski@...el.com>
Cc: Björn Töpel <bjorn@...nel.org>,
 Magnus Karlsson <magnus.karlsson@...el.com>,
 Jonathan Lemon <jonathan.lemon@...il.com>,
 Alexei Starovoitov <ast@...nel.org>, Daniel Borkmann <daniel@...earbox.net>,
 Andrii Nakryiko <andrii@...nel.org>, Martin KaFai Lau
 <martin.lau@...ux.dev>, Eduard Zingerman <eddyz87@...il.com>,
 Song Liu <song@...nel.org>, Yonghong Song <yonghong.song@...ux.dev>,
 John Fastabend <john.fastabend@...il.com>, KP Singh <kpsingh@...nel.org>,
 Stanislav Fomichev <sdf@...ichev.me>, Hao Luo <haoluo@...gle.com>,
 Jiri Olsa <jolsa@...nel.org>, Mykola Lysenko <mykolal@...com>,
 Shuah Khan <shuah@...nel.org>, "David S. Miller" <davem@...emloft.net>,
 Jakub Kicinski <kuba@...nel.org>, Jesper Dangaard Brouer <hawk@...nel.org>,
 Thomas Petazzoni <thomas.petazzoni@...tlin.com>,
 Alexis Lothore <alexis.lothore@...tlin.com>, netdev@...r.kernel.org,
 bpf@...r.kernel.org, linux-kselftest@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH 00/13] selftests/bpf: Integrate test_xsk.c to test_progs
 framework

Hi Maciej

On 3/14/25 4:45 PM, Maciej Fijalkowski wrote:
> On Thu, Mar 13, 2025 at 11:47:58AM +0100, Bastien Curutchet (eBPF Foundation) wrote:
>> Hi all,
>>
>> This patch series continues the work to migrate the script tests into
>> prog_tests.
> 
> Hi Bastien,
> 
> the sole purpose of this is a cleanup of some sort?
> 

The goal is to have more tests run by the CI and fewer standalone 
scripts so that regressions are spotted more efficiently.

>>
>> The test_xsk.sh script tests lots of AF_XDP use cases. The tests it uses
>> are defined in xksxceiver.c. As this script is used to test real
>> hardware, the goal here is to keep it as is and only integrate the
>> tests on veth peers into the test_progs framework.
> 
> We're doubling the functionality for no additional benefits? Or the
> benefit of this set would be the veth xsk tests execution within BPF CI?
> 

Yes the benefit would be the tests execution within BPF CI.

>> Three tests are flaky on s390 so they won't be integrated to test_progs
>> yet (I'm currently trying to make them more robust).
>>
>> PATCH 1 & 2 fix some small issues xskxceiver.c
>> PATCH 3 to 9 rework the xskxceiver to ease the integration in the
>> test_progs framework. Two main points are addressed in them :
>>   - wrap kselftest calls behind macros to ease their replacement later
>>   - handle all errors to release resources instead of calling exit() when
>>     any error occurs.
>> PATCH 10 extracts test_xsk[.c/.h] from xskxceiver[.c/.h] to make the
>> tests available to test_progs
>> PATCH 11 enables kselftest de-activation
>> PATCH 12 isolates the flaky tests
>> PATCH 13 integrate the non-flaky tests to the test_progs framework
> 
> I didn't bisect but this set breaks the HW tests for me which *is* what we
> care about. I'll dig onto that on monday and will get back to you.
> 

Ok, thank you. Can you tell me what hardware you use please ? If by any 
chance I have the same HW somewhere in my office, I can try to reproduce 
on my side.

Best regards,
Bastien