linux-kernel - Re: [PATCH] firmware: thead: add CONFIG

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <d9f3b44e-a1f7-4441-a731-ea99990de871@samsung.com>
Date: Fri, 14 Mar 2025 17:39:19 +0100
From: Michal Wilczynski <m.wilczynski@...sung.com>
To: Arnd Bergmann <arnd@...nel.org>, Ulf Hansson <ulf.hansson@...aro.org>,
	Drew Fustini <drew@...7.com>
Cc: Arnd Bergmann <arnd@...db.de>, Guillaume La Roque
	<glaroque@...libre.com>, Krzysztof Kozlowski
	<krzysztof.kozlowski@...aro.org>, Tudor Ambarus <tudor.ambarus@...aro.org>,
	Prasad Pandit <pjp@...oraproject.org>, linux-kernel@...r.kernel.org
Subject: Re: [PATCH] firmware: thead: add CONFIG_MAILBOX dependency



On 3/14/25 16:48, Arnd Bergmann wrote:
> From: Arnd Bergmann <arnd@...db.de>
> 
> Without this, the driver fails to build:
> 
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_call_rpc':
> thead,th1520-aon.c:(.text+0x28): undefined reference to `mbox_send_message'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_deinit':
> thead,th1520-aon.c:(.text+0x17e): undefined reference to `mbox_free_channel'
> ld: drivers/firmware/thead,th1520-aon.o: in function `th1520_aon_init':
> thead,th1520-aon.c:(.text+0x1d9): undefined reference to `mbox_request_channel_byname'
> 
> Fixes: e4b3cbd840e5 ("firmware: thead: Add AON firmware protocol driver")
> Signed-off-by: Arnd Bergmann <arnd@...db.de>
> ---
>  drivers/firmware/Kconfig | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/firmware/Kconfig b/drivers/firmware/Kconfig
> index 42e3dd1c387a..6ab9f7ca7ff1 100644
> --- a/drivers/firmware/Kconfig
> +++ b/drivers/firmware/Kconfig
> @@ -239,6 +239,7 @@ config SYSFB_SIMPLEFB
>  config TH1520_AON_PROTOCOL
>  	tristate "Always-On firmware protocol"
>  	depends on ARCH_THEAD || COMPILE_TEST
> +	depends on MAILBOX
>  	help
>  	  Power, clock, and resource management capabilities on the TH1520 SoC are
>  	  managed by the E902 core. Firmware running on this core communicates with

Thanks, looks good shouldn't have missed that.

Reviewed-by: Michal Wilczynski <m.wilczynski@...sung.com>