[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-Id: <20250314-acpm-fixes-v1-3-ab03ca8e723f@linaro.org>
Date: Fri, 14 Mar 2025 16:40:03 +0000
From: André Draszik <andre.draszik@...aro.org>
To: Tudor Ambarus <tudor.ambarus@...aro.org>,
Krzysztof Kozlowski <krzk@...nel.org>,
Alim Akhtar <alim.akhtar@...sung.com>
Cc: Peter Griffin <peter.griffin@...aro.org>,
Will McVicker <willmcvicker@...gle.com>, kernel-team@...roid.com,
linux-kernel@...r.kernel.org, linux-samsung-soc@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org,
Krzysztof Kozlowski <krzysztof.kozlowski@...aro.org>,
André Draszik <andre.draszik@...aro.org>
Subject: [PATCH 3/3] firmware: exynos-acpm: convert to dev_err_probe() in
client API
dev_err_probe() exists to simplify code and unify error messages by
using its message template.
Convert the remaining dev_err() in acpm_get_by_phandle() to
dev_err_probe().
Signed-off-by: André Draszik <andre.draszik@...aro.org>
---
drivers/firmware/samsung/exynos-acpm.c | 10 ++++++----
1 file changed, 6 insertions(+), 4 deletions(-)
diff --git a/drivers/firmware/samsung/exynos-acpm.c b/drivers/firmware/samsung/exynos-acpm.c
index 48f1e3cacaa709ae703115169df138b659ddae44..03f907a95c6acd66d89cd8af2f52e7c6dadf492a 100644
--- a/drivers/firmware/samsung/exynos-acpm.c
+++ b/drivers/firmware/samsung/exynos-acpm.c
@@ -701,12 +701,14 @@ static const struct acpm_handle *acpm_get_by_phandle(struct device *dev,
link = device_link_add(dev, &pdev->dev, DL_FLAG_AUTOREMOVE_SUPPLIER);
if (!link) {
- dev_err(&pdev->dev,
- "Failed to create device link to consumer %s.\n",
- dev_name(dev));
+ int ret = -EINVAL;
+
+ dev_err_probe(&pdev->dev, ret,
+ "Failed to create device link to consumer %s.\n",
+ dev_name(dev));
platform_device_put(pdev);
module_put(pdev->dev.driver->owner);
- return ERR_PTR(-EINVAL);
+ return ERR_PTR(ret);
}
return &acpm->handle;
--
2.49.0.rc1.451.g8f38331e32-goog
Powered by blists - more mailing lists