linux-kernel - Re: [PATCH v4 0/5] ASoC: q6apm: fix under runs and fragment sizes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9RcvQBe523KITZW@hovoldconsulting.com>
Date: Fri, 14 Mar 2025 17:43:41 +0100
From: Johan Hovold <johan@...nel.org>
To: srinivas.kandagatla@...aro.org
Cc: broonie@...nel.org, perex@...ex.cz, tiwai@...e.com,
	krzysztof.kozlowski@...aro.org, linux-sound@...r.kernel.org,
	linux-arm-msm@...r.kernel.org, linux-kernel@...r.kernel.org,
	dmitry.baryshkov@...aro.org, johan+linaro@...nel.org
Subject: Re: [PATCH v4 0/5] ASoC: q6apm: fix under runs and fragment sizes

On Fri, Mar 14, 2025 at 02:32:15PM +0000, Srinivas Kandagatla wrote:
> From: Srinivas Kandagatla <srinivas.kandagatla@...aro.org>
> 
> On Qualcomm Audioreach setup, some of the audio artifacts are seen in
> both recording and playback. These patches fix issues by
> 1. Adjusting the fragment size that dsp can service.
> 2. schedule available playback buffers in time for dsp to not hit under runs 
> 3. remove some of the manual calculations done to get hardware pointer.
> 
> With these patches, am able to see significant Audio quality improvements.
> I have few more patches to optimize the dsp drivers, but for now am
> keeping this series simple to address the underruns and overruns issues
> noticed in pipewire setup.
> 
> Any testing would be appreciated.
> 
> Please note that on pipewire min-latency has to be set to 512 which
> reflects the DSP latency requirements of 10ms. You might see audio
> artifacts like glitches if you try to play audio below 256 latency.

> Changes since v3:
> 	- updated period size aligment patch with 10ms period size
> 	  contstriants.
> 
> Changes since v2:
> 	- dropped patch which is causing regression with pluseaudio.
> 	- setup period sizes only for capture path
> 	- fix underruns/overruns in dsp pipelines.
> 	- add fixes tag
> 	- add patch to fix buffer alignment
> 
> Changes since v1:
> 	- added new patches to fix the fragment size, pointer
> 	  calculations
> 	- updated to schedule only available buffers.
> 

I tested v4 on the X13s with PulseAudio and T14s with PipeWire.

I'm no longer noticing any regressions with PulseAudio, while this
series makes PipeWire actually usable.

I may be hearing some crackling with PipeWire when recording with the 
pavucontrol volume meters enabled which results in a quantum size of
256. But I guess that's to be expected. Playback seems to work also at
256 with v4.

Tested-by: Johan Hovold <johan+linaro@...nel.org>

Johan