linux-kernel - Re: [PATCH v2] accel/qaic: Fix integer overflow in qaic_validate

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6f53e1f6-3ac8-4828-9ef5-dbeb76ab1459@oss.qualcomm.com>
Date: Fri, 14 Mar 2025 10:46:18 -0600
From: Jeff Hugo <jeff.hugo@....qualcomm.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
Cc: Carl Vanderlip <quic_carlv@...cinc.com>, Oded Gabbay
 <ogabbay@...nel.org>,
        Jacek Lawrynowicz <jacek.lawrynowicz@...ux.intel.com>,
        Pranjal Ramajor Asha Kanojiya <quic_pkanojiy@...cinc.com>,
        Stanislaw Gruszka <stanislaw.gruszka@...ux.intel.com>,
        linux-arm-msm@...r.kernel.org, dri-devel@...ts.freedesktop.org,
        linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org
Subject: Re: [PATCH v2] accel/qaic: Fix integer overflow in
 qaic_validate_req()

On 3/7/2025 1:41 AM, Dan Carpenter wrote:
> These are u64 variables that come from the user via
> qaic_attach_slice_bo_ioctl().  Use check_add_overflow() to ensure that
> the math doesn't have an integer wrapping bug.
> 
> Cc: stable@...r.kernel.org
> Fixes: ff13be830333 ("accel/qaic: Add datapath")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Thanks!

Reviewed-by: Jeff Hugo <jeff.hugo@....qualcomm.com>