linux-kernel - Re: [net-next,v2,1/2] net: phy: realtek: Clean up RTL8211E ExtPage access

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250314190056.739f4d81@fedora-2.home>
Date: Fri, 14 Mar 2025 19:00:56 +0100
From: Maxime Chevallier <maxime.chevallier@...tlin.com>
To: Michael Klein <michael@...sekall.de>
Cc: Andrew Lunn <andrew@...n.ch>, Heiner Kallweit <hkallweit1@...il.com>,
 Russell King <linux@...linux.org.uk>, "David S. Miller"
 <davem@...emloft.net>, Eric Dumazet <edumazet@...gle.com>, Jakub Kicinski
 <kuba@...nel.org>, Paolo Abeni <pabeni@...hat.com>, netdev@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [net-next,v2,1/2] net: phy: realtek: Clean up RTL8211E ExtPage
 access

Hi Michael,

On Fri, 14 Mar 2025 12:15:44 +0100
Michael Klein <michael@...sekall.de> wrote:

> - Factor out RTL8211E extension page access code to
>   rtl8211e_modify_ext_page()/rtl8211e_read_ext_page() and add some
>   related #define:s
> - Group RTL8211E_* and RTL8211F_* #define:s
> - Clean up rtl8211e_config_init()
> 
> Signed-off-by: Michael Klein <michael@...sekall.de>
> ---
[...]
> +static int rtl8211e_read_ext_page(struct phy_device *phydev, u16 ext_page,
> +				  u32 regnum)
> +{
> +	int oldpage, ret = 0;
> +
> +	oldpage = phy_select_page(phydev, RTL8211E_SET_EXT_PAGE);
> +	if (oldpage >= 0) {
> +		ret = __phy_write(phydev, RTL8211E_EXT_PAGE_SELECT, ext_page);
> +		if (!ret)
> +			ret = __phy_read(phydev, regnum);
> +	}
> +
> +	return phy_restore_page(phydev, oldpage, ret);
> +}

You're not using that function at all in this patch, so this patch
compiles with a warning for an unused function.

I suggest you move that to patch 2, which is the first user for 
rtl8211e_read_ext_page()

Thanks,

Maxime