linux-kernel - Re: [PATCH ath-next v9 13/13] wifi: ath12k: enable ath12k AHB support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <17e98c93-77a4-4caa-9378-bfa22b077f3a@oss.qualcomm.com>
Date: Thu, 13 Mar 2025 16:59:57 -0700
From: Jeff Johnson <jeff.johnson@....qualcomm.com>
To: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>, ath12k@...ts.infradead.org
Cc: Johannes Berg <johannes@...solutions.net>, Rob Herring <robh@...nel.org>,
        Krzysztof Kozlowski <krzk+dt@...nel.org>,
        Conor Dooley
 <conor+dt@...nel.org>,
        Jeff Johnson <jjohnson@...nel.org>, linux-wireless@...r.kernel.org,
        devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
        Balamurugan S <quic_bselvara@...cinc.com>,
        P Praneesh <quic_ppranees@...cinc.com>
Subject: Re: [PATCH ath-next v9 13/13] wifi: ath12k: enable ath12k AHB support

On 3/5/2025 10:55 AM, Raj Kumar Bhagat wrote:
> From: Balamurugan S <quic_bselvara@...cinc.com>
> 
> Currently only PCI devices are supported in Ath12k driver. Refactor
> Ath12k module_init and module_exit to include Ath12k AHB support.
> 
> Add Ath12k AHB support in Kconfig with dependency on Remoteproc
> driver. Ath12k AHB support relies on remoteproc driver for firmware
> download, power up/down etc.
> 
> Tested-on: IPQ5332 hw1.0 AHB WLAN.WBE.1.3.1-00130-QCAHKSWPL_SILICONZ-1
> Tested-on: QCN9274 hw2.0 PCI WLAN.WBE.1.1.1-00210-QCAHKSWPL_SILICONZ-1
> 
> Signed-off-by: Balamurugan S <quic_bselvara@...cinc.com>
> Co-developed-by: P Praneesh <quic_ppranees@...cinc.com>
> Signed-off-by: P Praneesh <quic_ppranees@...cinc.com>
> Signed-off-by: Raj Kumar Bhagat <quic_rajkbhag@...cinc.com>
> ---
>  drivers/net/wireless/ath/ath12k/Kconfig  |  6 ++++
>  drivers/net/wireless/ath/ath12k/Makefile |  1 +
>  drivers/net/wireless/ath/ath12k/ahb.h    | 11 ++++++++
>  drivers/net/wireless/ath/ath12k/core.c   | 35 ++++++++++++++++++++++--
>  drivers/net/wireless/ath/ath12k/pci.c    | 10 ++-----
>  drivers/net/wireless/ath/ath12k/pci.h    |  4 ++-
>  6 files changed, 55 insertions(+), 12 deletions(-)
> 
> diff --git a/drivers/net/wireless/ath/ath12k/Kconfig b/drivers/net/wireless/ath/ath12k/Kconfig
> index 52a1bb19e3da..b2bfcaca00b3 100644
> --- a/drivers/net/wireless/ath/ath12k/Kconfig
> +++ b/drivers/net/wireless/ath/ath12k/Kconfig
> @@ -15,6 +15,12 @@ config ATH12K
>  
>  	  If you choose to build a module, it'll be called ath12k.
>  
> +config ATH12K_AHB
> +	bool "QTI ath12k AHB support"
> +	depends on ATH12K && REMOTEPROC && QCOM_Q6V5_WCSS_SEC

Just to state publicly what I said to you privately, I cannot accept this
series since I cannot enable the feature, even to do a sanity build, since the
patchset that introduces QCOM_Q6V5_WCSS_SEC is not yet accepted.

So moving this to deferred in patchwork. Let me know when QCOM_Q6V5_WCSS_SEC
is accepted.

/jeff