linux-kernel - Re: [PATCH v3] USB: serial: ftdi_sio: add support for Altera USB Blaster 3

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9PZkX12YX1sbvSt@hovoldconsulting.com>
Date: Fri, 14 Mar 2025 08:24:01 +0100
From: Johan Hovold <johan@...nel.org>
To: "Ng, Boon Khai" <boon.khai.ng@...era.com>
Cc: Boon Khai Ng <boon.khai.ng@...el.com>,
	Greg Kroah-Hartman <gregkh@...uxfoundation.org>,
	linux-usb <linux-usb@...r.kernel.org>,
	linux-kernel <linux-kernel@...r.kernel.org>,
	"Ang, Tien Sung" <tien.sung.ang@...era.com>
Subject: Re: [PATCH v3] USB: serial: ftdi_sio: add support for Altera USB
 Blaster 3

On Fri, Mar 14, 2025 at 02:14:47AM +0000, Ng, Boon Khai wrote:
> > Thanks for the update, now applied.
> > 
> > Next time, remember to put your SoB above the (first) cut-off line (---) so that
> > it is included in the commit message when your patch is applied.
> > I fixed that up manually this time.
> 
> Thank you for your feedback and for applying the update.
> I apologize for the misunderstanding regarding the placement of the SoB. 
> I mistakenly thought I needed to create the cut-off line myself in the 
> commit message. 

No worries.

> I now understand that I should generate the patch first and then
> manually add the change log under the first cut-off line that
> appears below the sign-off.

That's what I do, but if you add your SoB followed by a cut-off line and
change log to your local commit, then that should also work if you later
run git-format-patch.

Johan