linux-kernel - Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing function

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314080022.GH3645863@google.com>
Date: Fri, 14 Mar 2025 08:00:22 +0000
From: Lee Jones <lee@...nel.org>
To: Artur Weber <aweber.kernel@...il.com>
Cc: Mark Brown <broonie@...nel.org>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Florian Fainelli <florian.fainelli@...adcom.com>,
	Ray Jui <rjui@...adcom.com>, Scott Branden <sbranden@...adcom.com>,
	Broadcom internal kernel review list <bcm-kernel-feedback-list@...adcom.com>,
	Stanislav Jakubek <stano.jakubek@...il.com>,
	devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
	linux-arm-kernel@...ts.infradead.org,
	~postmarketos/upstreaming@...ts.sr.ht
Subject: Re: [PATCH v6 06/10] mfd: bcm590xx: Add PMU ID/revision parsing
 function

On Thu, 13 Mar 2025, Artur Weber wrote:

> On 13.03.2025 14:25, Mark Brown wrote:
> > On Thu, Mar 13, 2025 at 01:20:36PM +0000, Lee Jones wrote:
> > > On Tue, 04 Mar 2025, Artur Weber wrote:
> > 
> > > > +	if (id != bcm590xx->pmu_id) {
> > > > +		dev_err(bcm590xx->dev,
> > > > +			"Incorrect ID for %s: expected %x, got %x. Check your DT compatible.\n",
> > > 
> > > Isn't it more likely that the H/W this is being executed on is
> > > unsupported?  If so, say that instead.
> > 
> > Given that the compatibles are device specific the driver shouldn't be
> > binding if the device is unsupported.
> 
> Yes, the intention here is just to make sure that the DT compatible and
> hardware ID match. Unsupported hardware would not have a DT compatible.

Right, so the user is utilising the correct compatible on the incorrect
(most likely unsupported) platform.  When using a supported DTB on
unknown hardware, the driver will bind but fail here.

-- 
Lee Jones [李琼斯]