linux-kernel - Re: [PATCH v7 06/10] iio: adc: Support ROHM BD79124 ADC

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <8de67803-e89d-42dc-ab4d-e4549819432c@gmail.com>
Date: Fri, 14 Mar 2025 10:52:36 +0200
From: Matti Vaittinen <mazziesaccount@...il.com>
To: Andy Shevchenko <andriy.shevchenko@...ux.intel.com>
Cc: Matti Vaittinen <matti.vaittinen@...rohmeurope.com>,
 Jonathan Cameron <jic23@...nel.org>, Lars-Peter Clausen <lars@...afoo.de>,
 Nuno Sa <nuno.sa@...log.com>, David Lechner <dlechner@...libre.com>,
 Javier Carrasco <javier.carrasco.cruz@...il.com>,
 Olivier Moysan <olivier.moysan@...s.st.com>,
 Guillaume Stols <gstols@...libre.com>,
 Dumitru Ceclan <mitrutzceclan@...il.com>,
 Trevor Gamblin <tgamblin@...libre.com>,
 Matteo Martelli <matteomartelli3@...il.com>,
 Alisa-Dariana Roman <alisadariana@...il.com>,
 João Paulo Gonçalves <joao.goncalves@...adex.com>,
 AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
 linux-kernel@...r.kernel.org, linux-iio@...r.kernel.org
Subject: Re: [PATCH v7 06/10] iio: adc: Support ROHM BD79124 ADC

On 14/03/2025 09:31, Matti Vaittinen wrote:
> On 13/03/2025 15:19, Andy Shevchenko wrote:
>> On Thu, Mar 13, 2025 at 09:19:03AM +0200, Matti Vaittinen wrote:

>>> +static int bd79124_chan_init(struct bd79124_data *data, int channel)
>>> +{
>>> +    int ret;
>>> +
>>> +    ret = regmap_write(data->map, 
>>> BD79124_GET_HIGH_LIMIT_REG(channel), 4095);
>>
>> BD79124_HIGH_LIMIT_MAX ?
>>
>>> +    if (ret)
>>> +        return ret;
>>> +
>>> +    return regmap_write(data->map, 
>>> BD79124_GET_LOW_LIMIT_REG(channel), 0);
>>
>> BD79124_HIGH_LIMIT_MIN ?
> 
> I think I originally had these defines but I was probably asked to drop 
> the defines and use raw values instead.

Please ignore my reply here! It seems I still have the defines in other 
places of the code so they haven't been dropped after all. I'll replace 
the raw values as you suggested.

Thanks.

Yours,
	-- Matti