linux-kernel - Re: [PATCH 4/5] x86/syscall/x32: Move x32 syscall table

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <Z9P4Fx9Kl7mkSh9F@gmail.com>
Date: Fri, 14 Mar 2025 10:34:15 +0100
From: Ingo Molnar <mingo@...nel.org>
To: Sohil Mehta <sohil.mehta@...el.com>
Cc: Brian Gerst <brgerst@...il.com>, linux-kernel@...r.kernel.org,
	x86@...nel.org, "H . Peter Anvin" <hpa@...or.com>,
	Thomas Gleixner <tglx@...utronix.de>,
	Borislav Petkov <bp@...en8.de>, Andy Lutomirski <luto@...nel.org>,
	Juergen Gross <jgross@...e.com>,
	Boris Ostrovsky <boris.ostrovsky@...cle.com>
Subject: Re: [PATCH 4/5] x86/syscall/x32: Move x32 syscall table


* Sohil Mehta <sohil.mehta@...el.com> wrote:

> > +#ifdef CONFIG_X86_X32_ABI
> > +long x32_sys_call(const struct pt_regs *regs, unsigned int nr)
> > +{
> > +	switch (nr) {
> > +	#include <asm/syscalls_x32.h>
> > +	default: return __x64_sys_ni_syscall(regs);
> > +	}
> > +};
> 
> There seems to be a stray semicolon here. The original code also has it
> but it doesn't seem necessary.

BTW., seeing that you've gone through this series with a fine comb I've 
added your Reviewed-by tag to the series (with the caveat that the 
details you've pointed out will be addressed in followup patches).
Let me know if that's not OK.

Thanks,

	Ingo