linux-kernel - Re: 回复: [PATCH 3/5] pmic: mediatek: Add spmi pmic mfd driver

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <20250314094731.GA3890718@google.com>
Date: Fri, 14 Mar 2025 09:47:31 +0000
From: Lee Jones <lee@...nel.org>
To: Lu Tang (汤璐) <Lu.Tang@...iatek.com>
Cc: Jonathan Cameron <jic23@...nel.org>,
	Lars-Peter Clausen <lars@...afoo.de>, Rob Herring <robh@...nel.org>,
	Krzysztof Kozlowski <krzk+dt@...nel.org>,
	Conor Dooley <conor+dt@...nel.org>,
	Dmitry Torokhov <dmitry.torokhov@...il.com>,
	Matthias Brugger <matthias.bgg@...il.com>,
	AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>,
	Sean Wang <sean.wang@...nel.org>,
	Linus Walleij <linus.walleij@...aro.org>,
	Liam Girdwood <lgirdwood@...il.com>,
	Mark Brown <broonie@...nel.org>, Stephen Boyd <sboyd@...nel.org>,
	Chen Zhong (钟辰) <Chen.Zhong@...iatek.com>,
	Sen Chu (储森) <Sen.Chu@...iatek.com>,
	"linux-iio@...r.kernel.org" <linux-iio@...r.kernel.org>,
	"devicetree@...r.kernel.org" <devicetree@...r.kernel.org>,
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>,
	"linux-input@...r.kernel.org" <linux-input@...r.kernel.org>,
	"linux-arm-kernel@...ts.infradead.org" <linux-arm-kernel@...ts.infradead.org>,
	"linux-mediatek@...ts.infradead.org" <linux-mediatek@...ts.infradead.org>,
	"linux-gpio@...r.kernel.org" <linux-gpio@...r.kernel.org>,
	Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@...iatek.com>
Subject: Re: 回复: [PATCH 3/5] pmic: mediatek:
 Add spmi pmic mfd driver

On Fri, 14 Mar 2025, Lu Tang (汤璐) wrote:

> Update email address

What is this?

Please refrain from top-posting.

> -----邮件原件-----
> 发件人: Lu.Tang <Lu.Tang@...iatek.com> 
> 发送时间: 2025年3月14日 15:32
> 收件人: Jonathan Cameron <jic23@...nel.org>; Lars-Peter Clausen <lars@...afoo.de>; Rob Herring <robh@...nel.org>; Krzysztof Kozlowski <krzk+dt@...nel.org>; Conor Dooley <conor+dt@...nel.org>; Dmitry Torokhov <dmitry.torokhov@...il.com>; Lee Jones <lee@...nel.org>; Matthias Brugger <matthias.bgg@...il.com>; AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>; Sean Wang <sean.wang@...nel.org>; Linus Walleij <linus.walleij@...aro.org>; Liam Girdwood <lgirdwood@...il.com>; Mark Brown <broonie@...nel.org>; Stephen Boyd <sboyd@...nel.org>; Chen Zhong (钟辰) <Chen.Zhong@...iatek.com>; Sen Chu <shen.chu@...iatek.com>
> 抄送: linux-iio@...r.kernel.org; devicetree@...r.kernel.org; linux-kernel@...r.kernel.org; linux-input@...r.kernel.org; linux-arm-kernel@...ts.infradead.org; linux-mediatek@...ts.infradead.org; linux-gpio@...r.kernel.org; Project_Global_Chrome_Upstream_Group <Project_Global_Chrome_Upstream_Group@...iatek.com>; Lu Tang (汤璐) <Lu.Tang@...iatek.com>
> 主题: [PATCH 3/5] pmic: mediatek: Add spmi pmic mfd driver

Fix your mailer.  Headers have no place in the body of an email.

> From: "Lu.Tang" <lu.tang@...iatek.com>
> 
> Add spmi pmic mfd driver for mt8196

7 words for a 900 line change is not going to fly.

What is this device?  What does it provide?  What are its dependencies?

Etc.

> Signed-off-by: Lu Tang <lu.tang@...iatek.com>
> ---
>  drivers/mfd/Kconfig                  |  26 ++
>  drivers/mfd/Makefile                 |   2 +
>  drivers/mfd/mt6685-core.c            |  83 +++++
>  drivers/mfd/mtk-spmi-pmic.c          | 518 +++++++++++++++++++++++++++
>  include/linux/mfd/mt6363/core.h      | 134 +++++++
>  include/linux/mfd/mt6363/registers.h | 168 +++++++++
>  include/linux/mfd/mt6373/core.h      |  94 +++++
>  include/linux/mfd/mt6373/registers.h |  53 +++
>  8 files changed, 1078 insertions(+)
>  create mode 100644 drivers/mfd/mt6685-core.c  create mode 100644 drivers/mfd/mtk-spmi-pmic.c  create mode 100644 include/linux/mfd/mt6363/core.h  create mode 100644 include/linux/mfd/mt6363/registers.h
>  create mode 100644 include/linux/mfd/mt6373/core.h  create mode 100644 include/linux/mfd/mt6373/registers.h

Please try again.

-- 
Lee Jones [李琼斯]