linux-kernel - Re: RE: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250314-astonishing-astute-caracara-4ba78c-mkl@pengutronix.de>
Date: Fri, 14 Mar 2025 10:53:33 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: Bough Chen <haibo.chen@....com>
Cc: "mailhol.vincent@...adoo.fr" <mailhol.vincent@...adoo.fr>, 
	"Ciprian Marian Costea (OSS)" <ciprianmarian.costea@....nxp.com>, Han Xu <han.xu@....com>, 
	"u.kleine-koenig@...libre.com" <u.kleine-koenig@...libre.com>, "linux-can@...r.kernel.org" <linux-can@...r.kernel.org>, 
	"linux-kernel@...r.kernel.org" <linux-kernel@...r.kernel.org>, "imx@...ts.linux.dev" <imx@...ts.linux.dev>
Subject: Re: RE: [PATCH 1/2] can: flexcan: only set CAN_STATE_ERROR_ACTIVE
 when resume has no issue

On 14.03.2025 09:48:06, Bough Chen wrote:
> > > > Only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process has
> > > > no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
> > >
> > > When looking at the code, it makes no sense to set the can.state to
> > > CAN_STATE_ERROR_ACTIVE, if the device isn't up.
> > >
> > > The suspend function doesn't look correct, either. I'll send a v3.
> > 
> > After a suspend/resume cycle on a down interface, it will come up as
> > ERROR-ACTIVE.
> 
> Seems only need to handle the priv->can.state when netif_running(dev) return true in PM.

ACK - in both the suspend and the resume function.

regards,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)