linux-kernel - Re: [PATCH v2 1/2] usb: cdns3: Remove the invalid comment

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <426dd1a1-ec02-4eeb-9db8-1b6c33d83082@nfschina.com>
Date: Fri, 14 Mar 2025 18:00:33 +0800
From: liqiong <liqiong@...china.com>
To: Greg Kroah-Hartman <gregkh@...uxfoundation.org>
Cc: Peter Chen <peter.chen@...nel.org>, Pawel Laszczak <pawell@...ence.com>,
 Roger Quadros <rogerq@...nel.org>, linux-usb@...r.kernel.org,
 linux-kernel@...r.kernel.org
Subject: Re: [PATCH v2 1/2] usb: cdns3: Remove the invalid comment



在 2025/3/14 16:19, Greg Kroah-Hartman 写道:
> On Fri, Mar 14, 2025 at 04:02:48PM +0800, Li Qiong wrote:
>> The function don't return value, remove the invalid comment.
>>
>> Signed-off-by: Li Qiong <liqiong@...china.com>
>> ---
>>  drivers/usb/cdns3/cdns3-plat.c | 2 --
>>  1 file changed, 2 deletions(-)
>>
>> diff --git a/drivers/usb/cdns3/cdns3-plat.c b/drivers/usb/cdns3/cdns3-plat.c
>> index 59ec505e198a..735df88774e4 100644
>> --- a/drivers/usb/cdns3/cdns3-plat.c
>> +++ b/drivers/usb/cdns3/cdns3-plat.c
>> @@ -179,8 +179,6 @@ static int cdns3_plat_probe(struct platform_device *pdev)
>>  /**
>>   * cdns3_plat_remove() - unbind drd driver and clean up
>>   * @pdev: Pointer to Linux platform device
>> - *
>> - * Returns 0 on success otherwise negative errno
>>   */
>>  static void cdns3_plat_remove(struct platform_device *pdev)
>>  {
>> -- 
>> 2.30.2
>>
>>
> Hi,
>
> This is the friendly patch-bot of Greg Kroah-Hartman.  You have sent him
> a patch that has triggered this response.  He used to manually respond
> to these common problems, but in order to save his sanity (he kept
> writing the same thing over and over, yet to different people), I was
> created.  Hopefully you will not take offence and will fix the problem
> in your patch and resubmit it so that it can be accepted into the Linux
> kernel tree.
>
> You are receiving this message because of the following common error(s)
> as indicated below:
>
> - This looks like a new version of a previously submitted patch, but you
>   did not list below the --- line any changes from the previous version.
>   Please read the section entitled "The canonical patch format" in the
>   kernel file, Documentation/process/submitting-patches.rst for what
>   needs to be done here to properly describe this.
>
> If you wish to discuss this problem further, or you have questions about
> how to resolve this issue, please feel free to respond to this email and
> Greg will reply once he has dug out from the pending patches received
> from other developers.
>
> thanks,
>
> greg k-h's patch email bot

Thanks, I will  resend v3 patch.