linux-kernel - RE: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID:
 <TY3PR01MB1134649E12B12E9D86560F92B86D22@TY3PR01MB11346.jpnprd01.prod.outlook.com>
Date: Fri, 14 Mar 2025 10:15:06 +0000
From: Biju Das <biju.das.jz@...renesas.com>
To: Dan Carpenter <dan.carpenter@...aro.org>
CC: Wolfram Sang <wsa+renesas@...g-engineering.com>, Ulf Hansson
	<ulf.hansson@...aro.org>, "linux-mmc@...r.kernel.org"
	<linux-mmc@...r.kernel.org>, "linux-renesas-soc@...r.kernel.org"
	<linux-renesas-soc@...r.kernel.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>, "kernel-janitors@...r.kernel.org"
	<kernel-janitors@...r.kernel.org>
Subject: RE: [PATCH next] mmc: renesas_sdhi: fix error code in
 renesas_sdhi_probe()

Hi Dan Carpenter,

Thanks for the patch.


> -----Original Message-----
> From: Dan Carpenter <dan.carpenter@...aro.org>
> Sent: 14 March 2025 10:11
> Subject: [PATCH next] mmc: renesas_sdhi: fix error code in renesas_sdhi_probe()
> 
> If devm_regulator_register() fails then propagate the error code.  Don't return success.
> 
> Fixes: fae80a99dc03 ("mmc: renesas_sdhi: Add support for RZ/G3E SoC")
> Signed-off-by: Dan Carpenter <dan.carpenter@...aro.org>

Reviewed-by: Biju Das <biju.das.jz@...renesas.com>

Cheers,
Biju
> ---
>  drivers/mmc/host/renesas_sdhi_core.c | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/drivers/mmc/host/renesas_sdhi_core.c b/drivers/mmc/host/renesas_sdhi_core.c
> index 396fa2816a15..fa6526be3638 100644
> --- a/drivers/mmc/host/renesas_sdhi_core.c
> +++ b/drivers/mmc/host/renesas_sdhi_core.c
> @@ -1178,6 +1178,7 @@ int renesas_sdhi_probe(struct platform_device *pdev,
>  		of_node_put(rcfg.of_node);
>  		if (IS_ERR(rdev)) {
>  			dev_err(dev, "regulator register failed err=%ld", PTR_ERR(rdev));
> +			ret = PTR_ERR(rdev);
>  			goto efree;
>  		}
>  		priv->rdev = rdev;
> --
> 2.47.2