[<prev] [next>] [<thread-prev] [day] [month] [year] [list]
Message-ID: <CACRpkdZ=a0mbir=D3dCSPns1TC_OVWMMTXJKcTYOJeNy7aQ7NQ@mail.gmail.com>
Date: Fri, 14 Mar 2025 11:21:44 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: "Darren.Ye" <darren.ye@...iatek.com>
Cc: Liam Girdwood <lgirdwood@...il.com>, Mark Brown <broonie@...nel.org>,
Rob Herring <robh@...nel.org>, Krzysztof Kozlowski <krzk+dt@...nel.org>, Conor Dooley <conor+dt@...nel.org>,
Matthias Brugger <matthias.bgg@...il.com>,
AngeloGioacchino Del Regno <angelogioacchino.delregno@...labora.com>, Jaroslav Kysela <perex@...ex.cz>,
Takashi Iwai <tiwai@...e.com>, Bartosz Golaszewski <brgl@...ev.pl>, linux-sound@...r.kernel.org,
devicetree@...r.kernel.org, linux-kernel@...r.kernel.org,
linux-arm-kernel@...ts.infradead.org, linux-mediatek@...ts.infradead.org,
linux-gpio@...r.kernel.org
Subject: Re: [PATCH 06/14] ASoC: mediatek: mt8196: support audio GPIO control
Hi Darren,
thanks for your patch!
On Fri, Mar 7, 2025 at 1:49 PM Darren.Ye <darren.ye@...iatek.com> wrote:
> From: Darren Ye <darren.ye@...iatek.com>
>
> Implement mode switching for audio GPIO.
>
> Signed-off-by: Darren Ye <darren.ye@...iatek.com>
> +#include <linux/gpio.h>
Please don't include this legacy header. I don't think you even need it,
you are not using any gpio_ symbols at all.
> +#include <linux/pinctrl/consumer.h>
You don't seem to use anything from this include either.
Find more specific headers if you need the code to compile.
I think you should drop both, the name "GPIO" in this file is a bit confusing
because it's not very generic but dealing with audio IO routing. But I guess
it is what Mediatek calls it.
Yours,
Linus Walleij
Powered by blists - more mailing lists