linux-kernel - Re: [PATCH v3 10/13] i2c: xgene-slimpro: Simplify PCC shared memory region handling

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9QDl1afybO5RNKT@bogus>
Date: Fri, 14 Mar 2025 10:23:19 +0000
From: Sudeep Holla <sudeep.holla@....com>
To: Andi Shyti <andi.shyti@...nel.org>
Cc: linux-acpi@...r.kernel.org, linux-kernel@...r.kernel.org,
	Sudeep Holla <sudeep.holla@....com>,
	Jassi Brar <jassisinghbrar@...il.com>,
	Huisong Li <lihuisong@...wei.com>,
	Adam Young <admiyo@...amperecomputing.com>,
	Robbie King <robbiek@...ghtlabs.com>, linux-i2c@...r.kernel.org
Subject: Re: [PATCH v3 10/13] i2c: xgene-slimpro: Simplify PCC shared memory
 region handling

On Fri, Mar 14, 2025 at 01:48:30AM +0100, Andi Shyti wrote:
> Hi Sudeep,
> 
> On Thu, Mar 13, 2025 at 03:28:56PM +0000, Sudeep Holla wrote:
> > The PCC driver now handles mapping and unmapping of shared memory
> > areas as part of pcc_mbox_{request,free}_channel(). Without these before,
> > this xgene-slimpro I2C driver did handling of those mappings like several
> > other PCC mailbox client drivers.
> > 
> > There were redundant operations, leading to unnecessary code. Maintaining
> > the consistency across these driver was harder due to scattered handling
> > of shmem.
> > 
> > Just use the mapped shmem and remove all redundant operations from this
> > driver.
> > 
> > Cc: Andi Shyti <andi.shyti@...nel.org>
> > Cc: linux-i2c@...r.kernel.org
> > Signed-off-by: Sudeep Holla <sudeep.holla@....com>
> > ---
> 
> Acked-by: Andi Shyti <andi.shyti@...nel.org>
> 

Thanks!

-- 
Regards,
Sudeep