linux-kernel - RE: [PATCH v2 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID:
 <PSAPR06MB49492B48614D381498502A9089D22@PSAPR06MB4949.apcprd06.prod.outlook.com>
Date: Fri, 14 Mar 2025 10:39:59 +0000
From: Kevin Chen <kevin_chen@...eedtech.com>
To: Krzysztof Kozlowski <krzk@...nel.org>, "lee@...nel.org" <lee@...nel.org>,
	"robh@...nel.org" <robh@...nel.org>, "krzk+dt@...nel.org"
	<krzk+dt@...nel.org>, "conor+dt@...nel.org" <conor+dt@...nel.org>,
	"joel@....id.au" <joel@....id.au>, "andrew@...econstruct.com.au"
	<andrew@...econstruct.com.au>, "derek.kiernan@....com"
	<derek.kiernan@....com>, "dragan.cvetic@....com" <dragan.cvetic@....com>,
	"arnd@...db.de" <arnd@...db.de>, "gregkh@...uxfoundation.org"
	<gregkh@...uxfoundation.org>, "devicetree@...r.kernel.org"
	<devicetree@...r.kernel.org>, "linux-arm-kernel@...ts.infradead.org"
	<linux-arm-kernel@...ts.infradead.org>, "linux-aspeed@...ts.ozlabs.org"
	<linux-aspeed@...ts.ozlabs.org>, "linux-kernel@...r.kernel.org"
	<linux-kernel@...r.kernel.org>
Subject: RE: [PATCH v2 2/3] ARM: dts: aspeed-g6: Add AST2600 LPC PCC support

> On 04/03/2025 11:44, Kevin Chen wrote:
> > The AST2600 has PCC controller in LPC, placed in LPC node.
> >
> > Signed-off-by: Kevin Chen <kevin_chen@...eedtech.com>
> > ---
> >  arch/arm/boot/dts/aspeed/aspeed-g6.dtsi | 7 +++++++
> >  1 file changed, 7 insertions(+)
> >
> > diff --git a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > index 8ed715bd53aa..87dcacb78692 100644
> > --- a/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > +++ b/arch/arm/boot/dts/aspeed/aspeed-g6.dtsi
> > @@ -626,6 +626,13 @@ lpc_snoop: lpc-snoop@80 {
> >  					status = "disabled";
> >  				};
> >
> > +				lpc_pcc: lpc-pcc@0 {
> > +					compatible = "aspeed,ast2600-lpc-pcc";
> > +					reg = <0x0 0x140>;
> > +					interrupts = <GIC_SPI 145 IRQ_TYPE_LEVEL_HIGH>;
> > +					status = "disabled";
> 
> Incomplete. Your driver clearly bails on missing ports...
Agree.

> 
> Best regards,
> Krzysztof