linux-kernel - Re: [patch 6/7] irqchip: Convert generic irqchip locking to guards

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <CACRpkdYzi=MsXf2fzTiMZgtdF=5pxDCS1jJnB1JYKi4bxB4UXQ@mail.gmail.com>
Date: Fri, 14 Mar 2025 11:56:52 +0100
From: Linus Walleij <linus.walleij@...aro.org>
To: Thomas Gleixner <tglx@...utronix.de>
Cc: LKML <linux-kernel@...r.kernel.org>, Jiri Slaby <jirislaby@...nel.org>, 
	Talel Shenhar <talel@...zon.com>, Nicolas Ferre <nicolas.ferre@...rochip.com>, 
	Alexandre Belloni <alexandre.belloni@...tlin.com>, Claudiu Beznea <claudiu.beznea@...on.dev>, 
	Florian Fainelli <florian.fainelli@...adcom.com>, Guo Ren <guoren@...nel.org>, 
	Herve Codina <herve.codina@...tlin.com>, Huacai Chen <chenhuacai@...nel.org>, 
	Jiaxun Yang <jiaxun.yang@...goat.com>, Maxime Coquelin <mcoquelin.stm32@...il.com>, 
	Alexandre Torgue <alexandre.torgue@...s.st.com>, Chen-Yu Tsai <wens@...e.org>, 
	Jernej Skrabec <jernej.skrabec@...il.com>, Samuel Holland <samuel@...lland.org>, 
	Andrew Lunn <andrew@...n.ch>, Sebastian Hesselbarth <sebastian.hesselbarth@...il.com>, 
	Gregory Clement <gregory.clement@...tlin.com>, Uwe Kleine-König <ukleinek@...nel.org>, 
	Bartosz Golaszewski <brgl@...ev.pl>
Subject: Re: [patch 6/7] irqchip: Convert generic irqchip locking to guards

On Thu, Mar 13, 2025 at 3:31 PM Thomas Gleixner <tglx@...utronix.de> wrote:

> Conversion was done with Coccinelle and a few manual fixups.
>
> In a few interrupt chip callbacks this changes replaces
> raw_spin_lock_irqsave() with a guard(raw_spinlock). That's intended and
> correct because those interrupt chip callbacks are invoked with the
> interrupt descriptor lock held and interrupts disabled. No point in using
> the irqsave variant.
>
> No functional change.
>
> Signed-off-by: Thomas Gleixner <tglx@...utronix.de>
> Cc: Talel Shenhar <talel@...zon.com>
> Cc: Nicolas Ferre <nicolas.ferre@...rochip.com>
> Cc: Alexandre Belloni <alexandre.belloni@...tlin.com>
> Cc: Claudiu Beznea <claudiu.beznea@...on.dev>
> Cc: Florian Fainelli <florian.fainelli@...adcom.com>
> Cc: Guo Ren <guoren@...nel.org>
> Cc: Herve Codina <herve.codina@...tlin.com>
> Cc: Huacai Chen <chenhuacai@...nel.org>
> Cc: Jiaxun Yang <jiaxun.yang@...goat.com>
> Cc: Maxime Coquelin <mcoquelin.stm32@...il.com>
> Cc: Alexandre Torgue <alexandre.torgue@...s.st.com>
> Cc: Chen-Yu Tsai <wens@...e.org>
> Cc: Jernej Skrabec <jernej.skrabec@...il.com>
> Cc: Samuel Holland <samuel@...lland.org>

Reviewed-by: Linus Walleij <linus.walleij@...aro.org>

Yours,
Linus Walleij