linux-kernel - Re: [PATCH v7 44/49] x86/resctrl: Relax some asm #includes

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <03b02d77-a9c6-4f36-9471-06713d8eec07@arm.com>
Date: Fri, 14 Mar 2025 12:00:50 +0000
From: James Morse <james.morse@....com>
To: Fenghua Yu <fenghuay@...dia.com>, x86@...nel.org,
 linux-kernel@...r.kernel.org
Cc: Reinette Chatre <reinette.chatre@...el.com>,
 Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
 Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
 Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
 D Scott Phillips OS <scott@...amperecomputing.com>,
 carl@...amperecomputing.com, lcherian@...vell.com,
 bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
 baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
 Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
 dfustini@...libre.com, amitsinght@...vell.com,
 David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
 Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
 Shanker Donthineni <sdonthineni@...dia.com>
Subject: Re: [PATCH v7 44/49] x86/resctrl: Relax some asm #includes

Hi Fenghua,

On 07/03/2025 02:30, Fenghua Yu wrote:
> On 2/28/25 11:59, James Morse wrote:
>> From: Dave Martin<Dave.Martin@....com>
>>
>> checkpatch.pl identifies some direct #includes of asm headers that
>> can be satisfied by including the corresponding <linux/...> header
>> instead.
>>
>> Fix them.
>>
>> No intentional functional change.

> The commit message doesn't mention the rid initialization code changes?

That looks like another patch has been squashed in here - this was something Tony
identified as rid would be un-initialised if the rdt resource array grows behind x86's back.

[...]

> Other than that,
> 
> Reviewed-by: Fenghua Yu<fenghuay@...dia.com>


Thanks,

James