[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]
Message-ID: <d6e9881b-8c29-468f-8d58-a81240cbdc27@arm.com>
Date: Fri, 14 Mar 2025 12:01:13 +0000
From: James Morse <james.morse@....com>
To: Fenghua Yu <fenghuay@...dia.com>, x86@...nel.org,
linux-kernel@...r.kernel.org
Cc: Reinette Chatre <reinette.chatre@...el.com>,
Thomas Gleixner <tglx@...utronix.de>, Ingo Molnar <mingo@...hat.com>,
Borislav Petkov <bp@...en8.de>, H Peter Anvin <hpa@...or.com>,
Babu Moger <Babu.Moger@....com>, shameerali.kolothum.thodi@...wei.com,
D Scott Phillips OS <scott@...amperecomputing.com>,
carl@...amperecomputing.com, lcherian@...vell.com,
bobo.shaobowang@...wei.com, tan.shaopeng@...itsu.com,
baolin.wang@...ux.alibaba.com, Jamie Iles <quic_jiles@...cinc.com>,
Xin Hao <xhao@...ux.alibaba.com>, peternewman@...gle.com,
dfustini@...libre.com, amitsinght@...vell.com,
David Hildenbrand <david@...hat.com>, Rex Nie <rex.nie@...uarmicro.com>,
Dave Martin <dave.martin@....com>, Koba Ko <kobak@...dia.com>,
Shanker Donthineni <sdonthineni@...dia.com>,
Shaopeng Tan <tan.shaopeng@...fujitsu.com>, Tony Luck <tony.luck@...el.com>
Subject: Re: [PATCH v7 40/49] fs/resctrl: Add boiler plate for external
resctrl code
Hi Fenghua,
On 07/03/2025 02:16, Fenghua Yu wrote:
> On 2/28/25 11:59, James Morse wrote:
>> Add Makefile and Kconfig for fs/resctrl. Add ARCH_HAS_CPU_RESCTRL
>> for the common parts of the resctrl interface and make X86_CPU_RESCTRL
>> select this.
>>
>> Adding an include of asm/resctrl.h to linux/resctrl.h allows the
>> /fs/resctrl files to switch over to using this header instead.
>> diff --git a/fs/resctrl/pseudo_lock_trace.h b/fs/resctrl/pseudo_lock_trace.h
>> new file mode 100644
>> index 000000000000..e69de29bb2d1
>
> If merge patch 45 and 46 together to fix the pseudo_lock_trace.h compilation fatal issue,
> it's unnecessary to create pseudo_lock_trace.h here (and then the empty
> pseudo_lock_trace.h file will be deleted later in merged patch 45).
Sure, I 'll try and remember to note that on the cover letter for whoever choses to squash
those patches together.
[..]
> Other than that,
>
> Reviewed-by: Fenghua Yu <fenghua.yu@...el.com>
Thanks,
James
Powered by blists - more mailing lists