linux-kernel - Re: [PATCH 2/2] tcp: fix forever orphan socket caused by tcp

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <2025031411-sandbag-scabby-eb1c@gregkh>
Date: Fri, 14 Mar 2025 13:24:26 +0100
From: Greg KH <gregkh@...uxfoundation.org>
To: Youngmin Nam <youngmin.nam@...sung.com>
Cc: stable@...r.kernel.org, ncardwell@...gle.com, edumazet@...gle.com,
	kuba@...nel.org, davem@...emloft.net, dsahern@...nel.org,
	pabeni@...hat.com, horms@...nel.org, guo88.liu@...sung.com,
	yiwang.cai@...sung.com, netdev@...r.kernel.org,
	linux-kernel@...r.kernel.org, joonki.min@...sung.com,
	hajun.sung@...sung.com, d7271.choe@...sung.com, sw.ju@...sung.com,
	dujeong.lee@...sung.com, ycheng@...gle.com, yyd@...gle.com,
	kuro@...oa.me, cmllamas@...gle.com, willdeacon@...gle.com,
	maennich@...gle.com, gregkh@...gle.com,
	Lorenzo Colitti <lorenzo@...gle.com>,
	Jason Xing <kerneljasonxing@...il.com>
Subject: Re: [PATCH 2/2] tcp: fix forever orphan socket caused by tcp_abort

On Fri, Mar 14, 2025 at 06:24:46PM +0900, Youngmin Nam wrote:
> From: Xueming Feng <kuro@...oa.me>
> 
> commit bac76cf89816bff06c4ec2f3df97dc34e150a1c4 upstream.
> 
> We have some problem closing zero-window fin-wait-1 tcp sockets in our
> environment. This patch come from the investigation.
> 
> Previously tcp_abort only sends out reset and calls tcp_done when the
> socket is not SOCK_DEAD, aka orphan. For orphan socket, it will only
> purging the write queue, but not close the socket and left it to the
> timer.
> 
> While purging the write queue, tp->packets_out and sk->sk_write_queue
> is cleared along the way. However tcp_retransmit_timer have early
> return based on !tp->packets_out and tcp_probe_timer have early
> return based on !sk->sk_write_queue.
> 
> This caused ICSK_TIME_RETRANS and ICSK_TIME_PROBE0 not being resched
> and socket not being killed by the timers, converting a zero-windowed
> orphan into a forever orphan.
> 
> This patch removes the SOCK_DEAD check in tcp_abort, making it send
> reset to peer and close the socket accordingly. Preventing the
> timer-less orphan from happening.
> 
> According to Lorenzo's email in the v1 thread, the check was there to
> prevent force-closing the same socket twice. That situation is handled
> by testing for TCP_CLOSE inside lock, and returning -ENOENT if it is
> already closed.
> 
> The -ENOENT code comes from the associate patch Lorenzo made for
> iproute2-ss; link attached below, which also conform to RFC 9293.
> 
> At the end of the patch, tcp_write_queue_purge(sk) is removed because it
> was already called in tcp_done_with_error().
> 
> p.s. This is the same patch with v2. Resent due to mis-labeled "changes
> requested" on patchwork.kernel.org.
> 
> Link: https://patchwork.ozlabs.org/project/netdev/patch/1450773094-7978-3-git-send-email-lorenzo@google.com/
> Fixes: c1e64e298b8c ("net: diag: Support destroying TCP sockets.")
> Signed-off-by: Xueming Feng <kuro@...oa.me>
> Tested-by: Lorenzo Colitti <lorenzo@...gle.com>
> Reviewed-by: Jason Xing <kerneljasonxing@...il.com>
> Reviewed-by: Eric Dumazet <edumazet@...gle.com>
> Link: https://patch.msgid.link/20240826102327.1461482-1-kuro@kuroa.me
> Signed-off-by: Jakub Kicinski <kuba@...nel.org>
> Cc: <stable@...r.kernel.org> # v5.10+

Does not apply to 6.1.y or older, what did you want this applied to?

thanks,

greg k-h