linux-kernel - Re: [PATCH v3 1/2] can: flexcan: only change CAN state when link up in system PM

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <20250314-succinct-tall-skunk-cf905e-mkl@pengutronix.de>
Date: Fri, 14 Mar 2025 13:27:04 +0100
From: Marc Kleine-Budde <mkl@...gutronix.de>
To: haibo.chen@....com
Cc: mailhol.vincent@...adoo.fr, ciprianmarian.costea@....nxp.com, 
	u.kleine-koenig@...libre.com, fabio.estevam@....com, festevam@...il.com, 
	linux-can@...r.kernel.org, linux-kernel@...r.kernel.org, stable@...r.kernel.org, 
	imx@...ts.linux.dev, han.xu@....com
Subject: Re: [PATCH v3 1/2] can: flexcan: only change CAN state when link up
 in system PM

On 14.03.2025 19:01:44, haibo.chen@....com wrote:
> From: Haibo Chen <haibo.chen@....com>
> 
> After a suspend/resume cycle on a down interface, it will come up as
> ERROR-ACTIVE.
> 
> $ ip -details -s -s a s dev flexcan0
> 3: flexcan0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN group default qlen 10
>     link/can  promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
>     can state STOPPED (berr-counter tx 0 rx 0) restart-ms 1000
> 
> $ sudo systemctl suspend
> 
> $ ip -details -s -s a s dev flexcan0
> 3: flexcan0: <NOARP,ECHO> mtu 16 qdisc pfifo_fast state DOWN group default qlen 10
>     link/can  promiscuity 0 allmulti 0 minmtu 0 maxmtu 0
>     can state ERROR-ACTIVE (berr-counter tx 0 rx 0) restart-ms 1000
> 
> And only set CAN state to CAN_STATE_ERROR_ACTIVE when resume process
> has no issue, otherwise keep in CAN_STATE_SLEEPING as suspend did.
> 
> Fixes: 4de349e786a3 ("can: flexcan: fix resume function")
> Cc: stable@...r.kernel.org
> Signed-off-by: Haibo Chen <haibo.chen@....com>

Applied to linux-can.

Thanks,
Marc

-- 
Pengutronix e.K.                 | Marc Kleine-Budde          |
Embedded Linux                   | https://www.pengutronix.de |
Vertretung Nürnberg              | Phone: +49-5121-206917-129 |
Amtsgericht Hildesheim, HRA 2686 | Fax:   +49-5121-206917-9   |

Download attachment "signature.asc" of type "application/pgp-signature" (489 bytes)