linux-kernel - Re: [PATCH] rust: file: optimize rust symbol generation for FileDescriptorReservation

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [<thread-prev] [thread-next>] [day] [month] [year] [list]

Message-ID: <6c874a4f-439e-4ab2-807d-d0f59b9fe569@linux.dev>
Date: Fri, 14 Mar 2025 10:33:22 +0800
From: Kunwu Chan <kunwu.chan@...ux.dev>
To: Alice Ryhl <aliceryhl@...gle.com>
Cc: ojeda@...nel.org, alex.gaynor@...il.com, boqun.feng@...il.com,
 gary@...yguo.net, bjorn3_gh@...tonmail.com, benno.lossin@...ton.me,
 a.hindborg@...nel.org, tmgross@...ch.edu, dakr@...nel.org,
 nathan@...nel.org, nick.desaulniers+lkml@...il.com, morbo@...gle.com,
 justinstitt@...gle.com, rust-for-linux@...r.kernel.org,
 linux-kernel@...r.kernel.org, llvm@...ts.linux.dev,
 Kunwu Chan <kunwu.chan@...mail.com>, Grace Deng <Grace.Deng006@...il.com>
Subject: Re: [PATCH] rust: file: optimize rust symbol generation for
 FileDescriptorReservation

On 2025/3/13 18:47, Alice Ryhl wrote:
> On Thu, Mar 13, 2025 at 04:45:25PM +0800, Kunwu Chan wrote:
>> From: Kunwu Chan <kunwu.chan@...mail.com>
>>
>> When build the kernel using the llvm-18.1.3-rust-1.85.0-x86_64
>> with ARCH=arm64, the following symbols are generated:
>>
>> $ nm vmlinux | grep ' _R'.*FileDescriptorReservation | rustfilt
>> ffff8000805b6ef0 T <kernel::fs::file::FileDescriptorReservation>
>> 						::fd_install
>> ffff8000805b6e60 T <kernel::fs::file::FileDescriptorReservation>
>> 						::get_unused_fd_flags
>> ffff8000805b6f08 T <kernel::fs::file::FileDescriptorReservation
>> 					 as core::ops::drop::Drop>::drop
>>
>> These Rust symbols are trivial wrappers around the C functions
>> fd_install, put_unused_fd and put_task_struct.It
>> doesn't make sense to go through a trivial wrapper for these
>> functions, so mark them inline.
>>
>> After doing so, the above symbol will not in output.
>>
>> Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>
>> Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
>> Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
> A few notes:
>
> * Your own Signed-off-by must always be last.
> * You're missing Link: and Suggested-by: tags.

Thanks for the reply.

I'll change my own Signed-off-by be last and add Link and Suggested-by 
as the following:

Link: https://github.com/Rust-for-Linux/linux/issues/1145
Suggested-by: Alice Ryhl <aliceryhl@...gle.com>
Co-developed-by: Grace Deng <Grace.Deng006@...il.com>
Signed-off-by: Grace Deng <Grace.Deng006@...il.com>
Signed-off-by: Kunwu Chan <kunwu.chan@...mail.com>

> * There are some grammar issues, e.g. a missing space before "It" and
>    the phrase "will not in output" is not good.
I'll  add a space before "It" and remove the last line.
> * Let's also add the marker to `reserved_fd` to be on the safe side.
Sure, I'll make 'reserved_fd ' inline in v2.
> * I think it is easier to read the symbols if you list each sybmol on
>    one line like this:
>
> ffff8000805b6ef0 T <kernel::fs::file::FileDescriptorReservation>::fd_install
> ffff8000805b6e60 T <kernel::fs::file::FileDescriptorReservation>::get_unused_fd_flags
> ffff8000805b6f08 T <kernel::fs::file::FileDescriptorReservation as core::ops::drop::Drop>::drop

If in one line, checkpatch.pl will report a warning:

WARNING:Prefer a maximum 75 chars per line (possible unwrapped commit 
description?)

If no need to  bother with the warning, I'll change it to one line in v2.

>
> Alice



-- 
Thanks,
   Kunwu.Chan(Tao.chan)