linux-kernel - [PATCH] dyndbg: use sysfs_emit() instead of scnprintf()

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250315140743750cHJ6I1rOluLjS4m5GCKjr@zte.com.cn>
Date: Sat, 15 Mar 2025 14:07:43 +0800 (CST)
From: <xie.ludan@....com.cn>
To: <akpm@...ux-foundation.org>
Cc: <jbaron@...mai.com>, <jim.cromie@...il.com>,
        <linux-kernel@...r.kernel.org>, <xie.ludan@....com.cn>
Subject: [PATCH] dyndbg: use sysfs_emit() instead of scnprintf()

From: XieLudan

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: XieLudan
---
lib/dynamic_debug.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/lib/dynamic_debug.c b/lib/dynamic_debug.c
index 5a007952f7f2..83ce3f310ab9 100644
--- a/lib/dynamic_debug.c
+++ b/lib/dynamic_debug.c
@@ -795,11 +795,11 @@ int param_get_dyndbg_classes(char *buffer, const struct kernel_param *kp)

case DD_CLASS_TYPE_DISJOINT_NAMES:
case DD_CLASS_TYPE_DISJOINT_BITS:
- return scnprintf(buffer, PAGE_SIZE, "0x%lx\n", *dcp->bits);
+ return sysfs_emit(buffer, "0x%lx\n", *dcp->bits);

case DD_CLASS_TYPE_LEVEL_NAMES:
case DD_CLASS_TYPE_LEVEL_NUM:
- return scnprintf(buffer, PAGE_SIZE, "%d\n", *dcp->lvl);
+ return sysfs_emit(buffer, "%d\n", *dcp->lvl);
default:
return -1;
}
--
2.25.1