linux-kernel - [PATCH linux-next] perf/core: use sysfs

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite: Windows password security audit tool. GUI, reports in PDF.

[<prev] [next>] [day] [month] [year] [list]

Message-ID: <20250315141738452lXIH39UJAXlCmcATCzcBv@zte.com.cn>
Date: Sat, 15 Mar 2025 14:17:38 +0800 (CST)
From: <xie.ludan@....com.cn>
To: <peterz@...radead.org>
Cc: <mingo@...hat.com>, <acme@...nel.org>, <namhyung@...nel.org>,
        <mark.rutland@....com>, <alexander.shishkin@...ux.intel.com>,
        <jolsa@...nel.org>, <irogers@...gle.com>, <adrian.hunter@...el.com>,
        <kan.liang@...ux.intel.com>, <linux-perf-users@...r.kernel.org>,
        <linux-kernel@...r.kernel.org>
Subject: [PATCH linux-next] perf/core: use sysfs_emit() instead of scnprintf().

From: XieLudan <xie.ludan@....com.cn>

Follow the advice in Documentation/filesystems/sysfs.rst:
show() should only use sysfs_emit() or sysfs_emit_at() when formatting
the value to be returned to user space.

Signed-off-by: XieLudan <xie.ludan@....com.cn>
---
 kernel/events/core.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/kernel/events/core.c b/kernel/events/core.c
index 96f957035c6e..209250f4851a 100644
--- a/kernel/events/core.c
+++ b/kernel/events/core.c
@@ -11698,7 +11698,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,
 {
 	struct pmu *pmu = dev_get_drvdata(dev);
 
-	return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu->nr_addr_filters);
+	return sysfs_emit(page, "%d\n", pmu->nr_addr_filters);
 }
 DEVICE_ATTR_RO(nr_addr_filters);
 
@@ -11709,7 +11709,7 @@ type_show(struct device *dev, struct device_attribute *attr, char *page)
 {
 	struct pmu *pmu = dev_get_drvdata(dev);
 
-	return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu->type);
+	return sysfs_emit(page, "%d\n", pmu->type);
 }
 static DEVICE_ATTR_RO(type);
 
@@ -11720,7 +11720,7 @@ perf_event_mux_interval_ms_show(struct device *dev,
 {
 	struct pmu *pmu = dev_get_drvdata(dev);
 
-	return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu->hrtimer_interval_ms);
+	return sysfs_emit(page, "%d\n", pmu->hrtimer_interval_ms);
 }
 
 static DEFINE_MUTEX(mux_interval_mutex);
-- 
2.25.1
<div class="zcontentRow"><p><span style="font-family: Arial, Helvetica, &quot;Microsoft Yahei&quot;, sans-serif; background-color: rgb(255, 255, 255);">From: XieLudan &lt;xie.ludan@....com.cn&gt;</span></p><p><br></p><p>Follow the advice in Documentation/filesystems/sysfs.rst:</p><p>show() should only use sysfs_emit() or sysfs_emit_at() when formatting</p><p>the value to be returned to user space.</p><p><br></p><p>Signed-off-by: XieLudan &lt;xie.ludan@....com.cn&gt;</p><p>---</p><p>&nbsp;kernel/events/core.c | 6 +++---</p><p>&nbsp;1 file changed, 3 insertions(+), 3 deletions(-)</p><p><br></p><p>diff --git a/kernel/events/core.c b/kernel/events/core.c</p><p>index 96f957035c6e..209250f4851a 100644</p><p>--- a/kernel/events/core.c</p><p>+++ b/kernel/events/core.c</p><p>@@ -11698,7 +11698,7 @@ static ssize_t nr_addr_filters_show(struct device *dev,</p><p>&nbsp;{</p><p>&nbsp;<span style="white-space:pre">	</span>struct pmu *pmu = dev_get_drvdata(dev);</p><p>&nbsp;</p><p>-<span style="white-space:pre">	</span>return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu-&gt;nr_addr_filters);</p><p>+<span style="white-space:pre">	</span>return sysfs_emit(page, "%d\n", pmu-&gt;nr_addr_filters);</p><p>&nbsp;}</p><p>&nbsp;DEVICE_ATTR_RO(nr_addr_filters);</p><p>&nbsp;</p><p>@@ -11709,7 +11709,7 @@ type_show(struct device *dev, struct device_attribute *attr, char *page)</p><p>&nbsp;{</p><p>&nbsp;<span style="white-space:pre">	</span>struct pmu *pmu = dev_get_drvdata(dev);</p><p>&nbsp;</p><p>-<span style="white-space:pre">	</span>return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu-&gt;type);</p><p>+<span style="white-space:pre">	</span>return sysfs_emit(page, "%d\n", pmu-&gt;type);</p><p>&nbsp;}</p><p>&nbsp;static DEVICE_ATTR_RO(type);</p><p>&nbsp;</p><p>@@ -11720,7 +11720,7 @@ perf_event_mux_interval_ms_show(struct device *dev,</p><p>&nbsp;{</p><p>&nbsp;<span style="white-space:pre">	</span>struct pmu *pmu = dev_get_drvdata(dev);</p><p>&nbsp;</p><p>-<span style="white-space:pre">	</span>return scnprintf(page, PAGE_SIZE - 1, "%d\n", pmu-&gt;hrtimer_interval_ms);</p><p>+<span style="white-space:pre">	</span>return sysfs_emit(page, "%d\n", pmu-&gt;hrtimer_interval_ms);</p><p>&nbsp;}</p><p>&nbsp;</p><p>&nbsp;static DEFINE_MUTEX(mux_interval_mutex);</p><p>--&nbsp;</p><p>2.25.1</p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p><p style="font-size:14px;font-family:微软雅黑,Microsoft YaHei;"><br></p></div>