linux-kernel - Re: [PATCH] crypto: virtio - Erase some sensitive memory when it is freed

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <Z9VDOK2c9JAfJZ_i@gondor.apana.org.au>
Date: Sat, 15 Mar 2025 17:07:04 +0800
From: Herbert Xu <herbert@...dor.apana.org.au>
To: Christophe JAILLET <christophe.jaillet@...adoo.fr>
Cc: "Michael S. Tsirkin" <mst@...hat.com>, Jason Wang <jasowang@...hat.com>,
	Xuan Zhuo <xuanzhuo@...ux.alibaba.com>,
	Eugenio Pérez <eperezma@...hat.com>,
	Gonglei <arei.gonglei@...wei.com>,
	"David S. Miller" <davem@...emloft.net>,
	linux-kernel@...r.kernel.org, kernel-janitors@...r.kernel.org,
	virtualization@...ts.linux.dev, linux-crypto@...r.kernel.org
Subject: Re: [PATCH] crypto: virtio - Erase some sensitive memory when it is
 freed

On Mon, Mar 03, 2025 at 08:08:04PM +0100, Christophe JAILLET wrote:
> virtcrypto_clear_request() does the same as the code here, but uses
> kfree_sensitive() for one of the free operation.
> 
> So, better safe than sorry, use virtcrypto_clear_request() directly to
> save a few lines of code and cleanly free the memory.
> 
> Signed-off-by: Christophe JAILLET <christophe.jaillet@...adoo.fr>
> ---
> I've no idea if this is needed or not, but it looks not consistent to me.
> 
> If safe as-is, maybe the kfree_sensitive() in virtcrypto_clear_request()
> should be removed instead.
> ---
>  drivers/crypto/virtio/virtio_crypto_core.c | 6 ++----
>  1 file changed, 2 insertions(+), 4 deletions(-)

Patch applied.  Thanks.
-- 
Email: Herbert Xu <herbert@...dor.apana.org.au>
Home Page: http://gondor.apana.org.au/~herbert/
PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt