linux-kernel - Re: [PATCH 15/20] x86/cpu/amd: Use named asm operands in asm_clear

lists.openwall.net		lists / announce owl-users owl-dev john-users john-dev passwdqc-users yescrypt popa3d-users / oss-security kernel-hardening musl sabotage tlsify passwords / crypt-dev xvendor / Bugtraq Full-Disclosure linux-kernel linux-netdev linux-ext4 linux-hardening linux-cve-announce PHC
Open Source and information security mailing list archives

Hash Suite for Android: free password hash cracker in your pocket

[<prev] [next>] [<thread-prev] [day] [month] [year] [list]

Message-ID: <CAFULd4bO6BKimOQgm8b1iBn4-fU59ZpH22WM_5whTuPDuv+sgg@mail.gmail.com>
Date: Sat, 15 Mar 2025 11:00:23 +0100
From: Uros Bizjak <ubizjak@...il.com>
To: Josh Poimboeuf <jpoimboe@...nel.org>
Cc: x86@...nel.org, linux-kernel@...r.kernel.org, 
	Linus Torvalds <torvalds@...ux-foundation.org>, Peter Zijlstra <peterz@...radead.org>, 
	Borislav Petkov <bp@...en8.de>, "H. Peter Anvin" <hpa@...or.com>, Andrew Cooper <andrew.cooper3@...rix.com>, 
	Ingo Molnar <mingo@...nel.org>
Subject: Re: [PATCH 15/20] x86/cpu/amd: Use named asm operands in asm_clear_divider()

On Sat, Mar 15, 2025 at 10:01 AM Uros Bizjak <ubizjak@...il.com> wrote:
>
> On Fri, Mar 14, 2025 at 10:42 PM Josh Poimboeuf <jpoimboe@...nel.org> wrote:
> >
> > Use named inline asm operands in preparation for using alternative_io().
> >
> > Signed-off-by: Josh Poimboeuf <jpoimboe@...nel.org>
> > ---
> >  arch/x86/include/asm/processor.h | 4 ++--
> >  1 file changed, 2 insertions(+), 2 deletions(-)
> >
> > diff --git a/arch/x86/include/asm/processor.h b/arch/x86/include/asm/processor.h
> > index a1baf2fc5f9b..b458ff0e4c79 100644
> > --- a/arch/x86/include/asm/processor.h
> > +++ b/arch/x86/include/asm/processor.h
> > @@ -709,8 +709,8 @@ static inline u32 per_cpu_l2c_id(unsigned int cpu)
> >   */
> >  static __always_inline void amd_clear_divider(void)
> >  {
> > -       asm volatile(ALTERNATIVE("", "div %2\n\t", X86_BUG_DIV0)
> > -                    :: "a" (0), "d" (0), "r" (1));
> > +       asm volatile(ALTERNATIVE("", "div %[one]\n\t", X86_BUG_DIV0)
> > +                    :: "a" (0), "d" (0), [one] "r" (1));
>
> Please remove trailing "\n\t" here and elsewhere.

Also, please change $subject to mention "amd_clear_divider", not
"asm_clear_divider".

Thanks,
Uros.